Skip to content

fix(web): retry importScripts NetworkErrors in attempt to mitigate errors loading models 🏠 - #16604

Open
mcdurdin wants to merge 1 commit into
stable-18.0from
fix/web/13862-retry-networkerror-on-importScripts
Open

mcdurdin wants to merge 1 commit into
stable-18.0from
fix/web/13862-retry-networkerror-on-importScripts

Conversation

@mcdurdin

Copy link
Copy Markdown
Member

A deeper workaround is applied in 19.0 (see for example #16565, #16586) but for 18.0, this is an attempt to bypass the constant issue of models failing to load with Chrome 152 and later versions, by retrying on failure.

Relates-to: #13862 (may fix)

User Testing

  • TEST_MODELS_ANDROID: On Keyman for Android, verify that text input and predictive text is working as normal.
  • TEST_MODELS_IOS: On Keyman for iOS, verify that text input and predictive text is working as normal.

…rors loading models

A deeper workaround is applied in 19.0 (see for example #16565, #16586)
but for 18.0, this is an attempt to bypass the constant issue of models
failing to load with Chrome 152 and later versions, by retrying on
failure.

Relates-to: #13862 (may fix)
@github-project-automation github-project-automation Bot moved this to Todo in Keyman Sep 18, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added the user-test-required User tests have not been completed label Sep 18, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

  • TEST_MODELS_ANDROID (OPEN)
  • TEST_MODELS_IOS (OPEN)
Results Template
# Test Results

* **TEST_MODELS_ANDROID (OPEN):** notes
* **TEST_MODELS_IOS (OPEN):** notes

Test Artifacts

@github-actions github-actions Bot added web/ and removed stable labels Sep 18, 2026
@keymanapp-test-bot keymanapp-test-bot Bot changed the title fix(web): retry importScripts NetworkErrors in attempt to mitigate errors loading models fix(web): retry importScripts NetworkErrors in attempt to mitigate errors loading models 🏠 Sep 18, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added this to the B19S2 milestone Sep 18, 2026

@jahorton jahorton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible issue - didn't we set Android to auto-reload its host WebView when encountering Web engine errors? Wouldn't that trigger on the first error output below if so?

I should probably double-check whether or not that's still in place.

@jahorton

Copy link
Copy Markdown
Contributor

I'll put together a 🍒 for #16548 to go alongside this; it'll cut off the highly-correlated paired error we've been getting.

@mcdurdin

Copy link
Copy Markdown
Member Author

Possible issue - didn't we set Android to auto-reload its host WebView when encountering Web engine errors? Wouldn't that trigger on the first error output below if so?

I should probably double-check whether or not that's still in place.

Just tested: console.warn is reported through to sentry as a warning but doesn't reload the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants