Skip to content

fix(android): suppress autocorrection of hardware keystroke input - #16606

Open
jahorton wants to merge 1 commit into
masterfrom
fix/android/suppress-hardware-autocorrect
Open

jahorton wants to merge 1 commit into
masterfrom
fix/android/suppress-hardware-autocorrect

Conversation

@jahorton

Copy link
Copy Markdown
Contributor

Fixes: #16602

Build-bot: skip release:web,android

This PR adds a "autocorrect suppression" flag to the Web engine's KeyEvent type, allowing us to precisely target cases where autocorrect should be suppressed.

Note that this will allow autocorrect to still occur for hardware keystrokes on the Web-based testing page; the OSK remains visible there during typing, so this should be fine. It's not "fine" for Android because hardware keystrokes auto-hide the OSK, leaving no way to bypass autocorrect.

User Testing

TEST_REPRO: Use Keyman for Android on a physical device and an external hardware keyboard and verify that the repro in the base issue no longer reproduces.

  1. Again, use a physical device with an external hardware keyboard for this test.
  2. Set the language to English.
  3. Using the external hardware keyboard, type m a r c, then tap the spacebar.
  4. Verify that no adjustment to the next occurs. The text should remain marc and not be transformed into March or march .

@keymanapp-test-bot

keymanapp-test-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

@jahorton

Copy link
Copy Markdown
Contributor Author

Oh, I assigned instead of requesting review... 🤦

@Meng-Heng

Copy link
Copy Markdown
Contributor

Test Specs

  1. Keyman for Android v19.0.288-alpha-test-16606
  2. Galaxy A05 Android v15.0
  3. Bluetooth Microsoft keyboard

Test Results

  • TEST_REPRO (PASSED):
  1. EuroLatin (SIL) with the English language pre-selected
  2. With the external hardware keyboard, type marc, then tap the spacebar
  3. VERIFIED: No adjustment to the next occurs, the text remains marc and not transformed into March or march .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

bug(web): typing with physical keyboard triggers autocorrect but should not

4 participants