Conversation
Fixes: #16602 Build-bot: skip release:web,android
User Test ResultsTest specification and instructions Test Artifacts |
Contributor
Author
|
Oh, I assigned instead of requesting review... 🤦 |
Contributor
Test Specs
Test Results
|
8 tasks
mcdurdin
approved these changes
Sep 21, 2026
ermshiperete
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16602
Build-bot: skip release:web,android
This PR adds a "autocorrect suppression" flag to the Web engine's
KeyEventtype, allowing us to precisely target cases where autocorrect should be suppressed.Note that this will allow autocorrect to still occur for hardware keystrokes on the Web-based testing page; the OSK remains visible there during typing, so this should be fine. It's not "fine" for Android because hardware keystrokes auto-hide the OSK, leaving no way to bypass autocorrect.
User Testing
TEST_REPRO: Use Keyman for Android on a physical device and an external hardware keyboard and verify that the repro in the base issue no longer reproduces.
marc, then tap the spacebar.marcand not be transformed intoMarchormarch.