fix(set-version): reject unmatched package selectors#967
Open
ychampion wants to merge 1 commit into
Open
Conversation
Validate every explicit package selector before mutating workspace or package manifests so release automation cannot silently succeed or partially update a workspace. Constraint: Preserve existing default workspace selection and valid explicit package behavior. Rejected: Validate selectors during the mutation loop | Mixed valid and missing selectors could partially update manifests. Confidence: high Scope-risk: narrow Directive: Keep explicit selector validation ahead of workspace-version and package writes. Tested: cargo test --locked --all-features; cargo clippy --locked --all-targets --all-features -- -D warnings; cargo fmt --all -- --check; built CLI missing/valid selector smokes; git diff --check Not-tested: Full CI on non-Linux platforms
ychampion
force-pushed
the
fix/set-version-missing-package
branch
from
50df9c8 to
bf3582e
Compare
epage
reviewed
Jul 13, 2026
Comment on lines
+19
to
+26
| .stdout_eq("") | ||
| .stderr_eq("Error: package missing doesn't exist\n"); | ||
|
|
||
| assert_ui().subset_matches(current_dir!().join("out"), &project_root); | ||
| } | ||
|
|
||
| #[cargo_test] | ||
| fn mixed_selection_is_atomic() { |
Collaborator
There was a problem hiding this comment.
Please follow the pattern of our tests, including
- One test per mod
- Using
file!["stdout.term.svg"]for snapshots
epage
reviewed
Jul 13, 2026
Collaborator
There was a problem hiding this comment.
We generally ask that people show the existing bug by adding the tests in their own commit, with them passing, then fix the issue and update the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A nonexistent
--packagecurrently exits successfully without doing anything. Mixed valid and invalid selectors can also update part of a workspace before the mistake is noticed.Closes #888.
Validation
cargo test --locked --all-featurescargo clippy --locked --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo-set-versionCLI smoke tests for missing and valid selectors