Skip to content

feat: support route-specific label overrides - #163

Merged
jer3m01 merged 4 commits into
mainfrom
theme-label-override
Aug 7, 2026
Merged

feat: support route-specific label overrides#163
jer3m01 merged 4 commits into
mainfrom
theme-label-override

Conversation

@LadyBluenotes

@LadyBluenotes LadyBluenotes commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds route to the overrides SolidBase route configuration.
  • Preserves the configured route labels in the version dropdown.
  • Updates the dev example and documentation.
  • Adds coverage for override validation and route config resolution.

@netlify

netlify Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploy Preview for solidbase ready!

Name Link
🔨 Latest commit 2a0604f
🔍 Latest deploy log https://app.netlify.com/projects/solidbase/deploys/6a761093a54f0d0008261600
😎 Deploy Preview https://deploy-preview-163--solidbase.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@LadyBluenotes
LadyBluenotes requested a review from jer3m01 July 22, 2026 02:15
@pkg-pr-new

pkg-pr-new Bot commented Jul 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/kobaltedev/solidbase/@kobalte/solidbase@163

commit: 2a0604f

>
<span class={styles.label}>{getOptionLabel(current())}</span>
<span class={styles.label}>
{config().versionLabel ?? getOptionLabel(current())}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versionLabel should override in getOptionLabel rather than doing it in the theme.

@jer3m01 jer3m01 changed the title feat(default-theme): support route-specific version labels feat: support route-specific label overrides Aug 7, 2026
@jer3m01
jer3m01 merged commit ce135bf into main Aug 7, 2026
8 checks passed
@jer3m01
jer3m01 deleted the theme-label-override branch August 7, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants