Skip to content

Add --delete-propagation-policy and --delete-timeout flags to kpt live destroy#4665

Open
aravindtga wants to merge 1 commit into
kptdev:mainfrom
Nordix:destroy-delete-propagation-timeout-flags
Open

Add --delete-propagation-policy and --delete-timeout flags to kpt live destroy#4665
aravindtga wants to merge 1 commit into
kptdev:mainfrom
Nordix:destroy-delete-propagation-timeout-flags

Conversation

@aravindtga

Copy link
Copy Markdown
Contributor

Description

  • Add --delete-propagation-policy and --delete-timeout flags to kpt live destroy, bringing it to parity with kpt live apply which already has --prune-propagation-policy and --prune-timeout.
  • The underlying cli-utils DestroyerOptions has supported DeletePropagationPolicy and DeleteTimeout since Refactor destroyer to use tasks kubernetes-sigs/cli-utils#366, but kpt was not exposing them as CLI flags.
    • --delete-propagation-policy: Controls how dependents are handled during deletion (Background, Foreground, Orphan). Default: Background.
    • --delete-timeout: How long to wait for resources to be fully deleted. Default: 0 (wait indefinitely).

Fixes #1461

Type of Change

  • Bug fix
  • Tests
  • Documentation

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

AI Disclosure

  • I have used AI in the creation of this PR.

If so, please describe how:

  • Kiro to investigate the issue, verify upstream support in cli-utils, generate unit tests and generate PR message.

@netlify

netlify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 51d62ec
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a639464809f6e00089300ca
😎 Deploy Preview https://deploy-preview-4665--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@aravindtga aravindtga self-assigned this Jul 24, 2026
@aravindtga
aravindtga force-pushed the destroy-delete-propagation-timeout-flags branch 4 times, most recently from 2c67291 to 59bff78 Compare July 24, 2026 15:10
…e destroy

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@aravindtga
aravindtga force-pushed the destroy-delete-propagation-timeout-flags branch from 59bff78 to 51d62ec Compare July 24, 2026 16:35
@sonarqubecloud

Copy link
Copy Markdown

@aravindtga
aravindtga marked this pull request as ready for review July 24, 2026 16:42
@aravindtga
aravindtga requested review from a team July 24, 2026 16:42
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. area/live enhancement New feature or request labels Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/live enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kpt live destroy command should be able to wait for resources to be removed

1 participant