[origin-review] anomalyco/opencode#47091 — CHECK

[kvnloo]

Why this matters

After plugins remap config keys to display names, opencode run --agent NAME could miss the exact key and silently run default_agent.

Evidence

Tip 2dd9941d5b1a1eb325a6a143ed58c8735ab68cc8:

• Live: cd packages/opencode && bun test test/cli/run/agent-flag.test.ts → 4 pass / 0 fail (exact match, case-insensitive match, unknown fail-closed, subagent reject)
• Evidence class: BEHAVIORAL

Invariant: unknown --agent fails closed with the registered name list; subagents are never accepted as run agents.

Ask (design, light) — prospective; non-blocking

1. Should agent resolution always be name-based (display) rather than config-key-based?
2. For never-again: should every CLI selector that can remap names share one fail-closed resolver?

---

---

Fork mirror of a sealed OSS review draft. Not posted upstream.

• origin: fix: fail closed on unknown --agent anomalyco/opencode#47091
• tip: 2dd9941d5b1a1eb325a6a143ed58c8735ab68cc8
• evidence: BEHAVIORAL — tip packages/opencode bun test test/cli/run/agent-flag.test.ts → 4/4 (exact/case match; unknown + subagent fail closed)
• pack: 05 draft 006
• dedupe_key: anomalyco/opencode#47091
• github_writes_origin: 0

[kvnloo]

REPAIR / RECON — old PR closed, bug reports remain open

Origin PR anomalyco#47091 is closed but anomalyco#47038 and anomalyco#47040 remain open. Do not resurrect the old branch blindly.

On current upstream dev:

1. reproduce an unknown --agent after plugin/config name remapping;
2. verify whether it still silently falls back to default_agent;
3. separately verify current --model/-m help/fallback semantics;
4. search for newer agent-resolution work;
5. if the fail-open bug persists, build a fresh current-dev fix with exact/case-insensitive known-name success, unknown-name failure, and subagent rejection;
6. keep the documentation-only --model item separate if code behavior is already correct.

Return repro status and canonical current owner.

[kvnloo]

RECON RESULT — fail-open persists on tip 696f41bc8e

Canonical owners (open): #47038 (unknown --agent), #47040 (docs --model pin). Closed unrepaired: anomalyco#47091, anomalyco#47051.

Repro / tip behavior

packages/opencode/src/cli/cmd/run.ts localAgent / attachAgent still:

1. agentSvc.get(name) exact object-key lookup (plugins can remap item.name away from the config key — see agent.ts item.name = value.name ?? item.name)
2. On miss or mode === "subagent": warn Falling back to default agent and return undefined → silent default_agent

No agent-flag.ts / test/cli/run/agent-flag.test.ts on tip.

--model / -m (separate)

Help text remains model to use in the format of provider/model (no pin/plugin-fallback note). pick() only splits provider/model and passes through — no silent rename fallback in CLI. Treat anomalyco#47040 as docs-only; keep out of this code fix per work order.

Newer agent-resolution work

Searched: no landed successor for fail-closed --agent. Open unrelated agent PRs exist; none replace this leaf.

Fresh fork repair (in flight)

Branch: fix/run-agent-fail-closed-v3 → https://github.com/kvnloo/opencode/tree/fix/run-agent-fail-closed-v3

Intended delta (from sealed anomalyco#47091):

• add resolveRequestedRunAgent (exact + case-insensitive; unknown fail; subagent reject)
• wire localAgent/attachAgent to process.exit(1) with registered primary name list
• unit tests 4/4; optional help-string clarify for --agent only (leave --model docs to Document that --model/-m pins and disables plugin fallback anomalyco/opencode#47040)

Commit push pending (box disk / App 403); branch at tip ready.

[kvnloo]

Report blob (batch-a/opencode-50.md)

# A6 — kvnloo/opencode#50 (--agent remapping)

- **Status:** repair_needed
- **Tip:** 696f41bc8e
- **Recon comment:** https://github.com/kvnloo/opencode/issues/50#issuecomment-5841718819
- **Fork branch:** https://github.com/kvnloo/opencode/tree/fix/run-agent-fail-closed-v3
- **Canonical:** origin #47038 open (fail-open); #47040 docs --model separate; #47091/#47051 closed unrepaired
- **Repro:** run.ts localAgent/attachAgent still warn + return undefined → silent default_agent. Agent.get is exact object-key; plugins remap .name.
- **--model:** help lacks pin note; pick() has no silent rename fallback — docs-only leaf.
- **Repair:** resolveRequestedRunAgent exact/case-insensitive; unknown fail; subagent reject; exit 1. Commit pending box disk full.

[kvnloo]

RESULT — done (fork repair landed)

• PR: fix(cli): fail closed on unknown --agent after remapping #62 (fix/run-agent-fail-closed-v3 → dev)
• Commit: 2dfa012 on tip 696f41bc8e
• Delta: resolveRequestedRunAgent exact + case-insensitive; unknown/subagent → process.exit(1) with primary agent list (no silent default_agent); --model help unchanged (docs-only Document that --model/-m pins and disables plugin fallback anomalyco/opencode#47040)

Test evidence

cd packages/opencode && bun test test/cli/run/agent-flag.test.ts
(pass) resolveRequestedRunAgent > matches exact registered names
(pass) resolveRequestedRunAgent > matches registered names case-insensitively
(pass) resolveRequestedRunAgent > fails closed on unknown names
(pass) resolveRequestedRunAgent > rejects subagents
  4 pass
  0 fail
  8 expect() calls
Ran 4 tests across 1 file.

Origin writes=0 (anomalyco untouched).

[kvnloo]

Current-dev recon: REPAIR_CANDIDATE, split code and docs.

Old PR anomalyco#47091 closed unmerged; anomalyco#47038 and anomalyco#47040 remain open. Current docs still explicitly describe unknown GitHub-action agent names as falling back to default_agent/build, so the fail-open contract has not clearly been retired.

On current dev:

1. reproduce opencode run --agent <unknown> after plugin/display-name remapping;
2. if it still silently falls back, build a fresh fail-closed resolver;
3. exact known + case-insensitive known succeed;
4. unknown errors with registered names;
5. subagent is rejected as run agent;
6. keep Document that --model/-m pins and disables plugin fallback anomalyco/opencode#47040 documentation about --model pin/fallback semantics separate unless code changes are required.

Do not resurrect the stale branch; return a fresh current-dev owner.

[kvnloo]

Cleanup classification: REPAIR_REQUIRED — old origin anomalyco#47091 closed; current-dev fail-closed agent repair remains required. Keep this canonical review thread open until a fresh current-dev repair lands or the bug is proven gone.