[origin-review] anomalyco/opencode#50702 — CHECK

[kvnloo]

Why this matters

Omitting tools on a configured model silently treated tools as available, enabling tool use the operator never opted into.

Evidence

Tip 21728771f202689abdb98c0f8942913ce9654a48 (base dev):

• Leaf: packages/core/src/config/provider.ts (+ plugin provider)
• Live: cd packages/core && bun test test/config/provider.test.ts → 4/4 pass including default-omitted-tools-false
• Evidence class: BEHAVIORAL

Invariant: omitted model tools ⇒ capability false.

Ask (design, light) — prospective; non-blocking

1. Is omit=false the permanent default for every capability flag, or only tools?
2. For never-again: should config schema make capability defaults explicit in generated docs?

---

---

Fork mirror of a sealed OSS review draft. Not posted upstream.

• origin: fix(config): default omitted model tools capability anomalyco/opencode#50702
• tip: 21728771f202689abdb98c0f8942913ce9654a48
• evidence: BEHAVIORAL — tip-native packages/core bun test test/config/provider.test.ts → 4/4 pass (incl. defaults omitted model tools capability to false)
• pack: 05 draft 008
• dedupe_key: anomalyco/opencode#50702
• github_writes_origin: 0

[kvnloo]

HOLD — resolve duplicate ownership before more testing

anomalyco#49940 is still open and targets the same omitted-tools/default-false contract. Do not post another generic validation until ownership is clear.

First compare anomalyco#50702 vs anomalyco#49940 on current heads:

1. exact schema/type changes;
2. normalization/default location;
3. whether both preserve explicit true/false;
4. whether either covers plugin-provided providers in addition to config providers;
5. which one is based on the current intended branch and has the stronger regression.

Then either:

• mark this mirror superseded and route QA to the canonical PR, or
• identify the unique invariant fix(config): default omitted model tools capability anomalyco/opencode#50702 adds and test only that delta.

No upstream promotion while two live PRs appear to own the same contract.

[kvnloo]

done — ownership compare vs anomalyco#49940 (no more generic validation)

Pin

	SHA
Work-order pin (still origin anomalyco#50702 head)	21728771f202689abdb98c0f8942913ce9654a48
Origin anomalyco#49940 head	9a54bbae1a47d2958007f63b5656a55a688efe8f

Ownership table (current heads)

Axis	anomalyco#50702	anomalyco#49940
Scope	Config-local Capabilities + plugin merge	Schema Model.Capabilities + normalize + tests
Schema/type change	Replaces ModelV2.Capabilities with local optional tools in config provider schema	tools: Boolean.withDecodingDefault(true) on schema model
Normalization / default location	Plugin apply: tools: config.capabilities.tools ?? **false**	Schema decode default: omitted → true
Explicit true / false preserved?	Yes (?? only when omitted)	Yes (default only when omitted)
Plugin-provided providers	Yes (touches config/plugin/provider.ts)	Config/provider plugin test covers configured models; schema default applies broadly
Branch / regression strength	Narrow (3 files, +43/−2); one focused unit	Broader (6 files, +160/−18); schema + normalize + multiple suites
Default when omitted	false	true

Decision

These PRs do not own the same contract — they conflict on the omitted-tools default (false vs true).

• Canonical for schema/default ownership: origin fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940 (schema-level decoding default = true, broader surface).
• fix(config): default omitted model tools capability anomalyco/opencode#50702 unique delta: config/plugin ?? false — this is a contradicting product choice, not a subset of fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940.
• Action: do not spray more generic validation. Product/maintainer must pick the intended omitted default before either PR is promoted. Until then, treat this mirror as ownership-blocked for promotion; route schema QA to fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940; keep fix(config): default omitted model tools capability anomalyco/opencode#50702 only if the intended default is explicitly false at the config/plugin boundary (then test only that ?? false delta against fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940’s true default).

Evidence

• Compare heads: fix(config): default omitted model tools capability anomalyco/opencode#50702 21728771… vs fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940 9a54bbae…
• Patches reviewed via GitHub API file diffs (schema/model.ts, config/normalize.ts, config/provider.ts, config/plugin/provider.ts, tests)
• Notes: /workspace/batch-a/opencode-52.md

No fork PR (analysis-only; no code). github_writes_origin=0.

[kvnloo]

Correction: origin anomalyco#49940 head SHA is 9a54bbae1a47d2958007f63b5656a55a688efe8f (typo in prior comment). Ownership conclusions unchanged.

[kvnloo]

WAIT_EXTERNAL — duplicate ownership hides a real semantic conflict

anomalyco#50702 and live anomalyco#49940 are not interchangeable implementations:

• fix(config): default omitted model tools capability anomalyco/opencode#50702: omitted tools → false
• fix(schema): default omitted capability tools for custom providers anomalyco/opencode#49940: omitted tools → true

Both aim to make migrated/custom provider configs load, but choosing the default changes model capability/security semantics.

Do not spend more test budget or post a generic validation until maintainers choose the intended default/owner.

Useful next action is a concise comparison for the origin thread:

• legacy V1/migration semantics;
• behavior of unknown models today;
• least-surprising backward-compatible default;
• explicit true/false preservation.

Then consolidate onto one PR.