fix(WhereUI): Make transient Locations loading diagnosable - #220
Open
kyleve wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Locations screen can briefly reveal its loading state when launch reaches ready before the scene-scoped year report finishes its first pull. Existing spans measured the work but could not distinguish a fresh scene model from an ordinary foreground refresh or say whether a headless drive had already completed. These events capture those facts before promotion or refresh changes them.
Interpretation:
foregroundEntered(... previous phase: ready)means the launch trunk had completed before the scene entered the foreground.activationStarted(... first: true, had report: false)identifies a fresh report model that can show initial loading.activationStarted(... first: false, had report: true)identifies a retained report performing a warm refresh without replacing the cards.Review focus
await, while emission remains on the existing typed Where log treeTesting
python3 -m unittest discover -s Tools/Tests -p 'test_snapshot_shards.py'(10 tests passed)./snapshot-shards check(42 suites assigned)./swiftformat --lint./test(7 backup-upgrader tests, 471 unit/integration tests, and 39 snapshot tests passed)