fix: reject invalidation without Redis - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98
Summary
Make explicit remote invalidation fail loudly when a
DialCacheinstance has no configured Redis client.invalidateRemote()with a focusedTypeErrorerror="invalidation"metricRoot cause and behavior
invalidateRemote()validatedfutureBufferMsand then returned successfully whenDialCacheConfig.rediswas absent. That fulfilled promise could tell a mutation path that a watermark had advanced even though no Redis operation occurred.The missing-client check now throws inside the existing invalidation failure path. Validation still runs first, observers remain fire-and-forget and isolated, and successful or failed configured-client calls follow the unchanged Redis path.
Compatibility
This intentionally changes only explicit remote maintenance calls on local-only instances. Applications that intentionally omit Redis should skip
invalidateRemote(); normal local-only cache reads and writes remain supported.Open batch-invalidation PR #114 is based on the same
maincommit. If it merges first, this branch must be rebased and extended so nonemptyinvalidateRemoteMany()calls receive the same failure and observability behavior while its documented empty-batch no-op is preserved.Validation
Node.js 22.22.0:
corepack pnpm checkcorepack pnpm test:integrationgit diff --checkpassed