Skip to content

fix(ci): handle Unicode paths in E2E domain selection - #2716

Open
hiSandog wants to merge 1 commit into
larksuite:mainfrom
hiSandog:fix/e2e-git-paths-20260911-a74d9c
Open

fix(ci): handle Unicode paths in E2E domain selection#2716
hiSandog wants to merge 1 commit into
larksuite:mainfrom
hiSandog:fix/e2e-git-paths-20260911-a74d9c

Conversation

@hiSandog

@hiSandog hiSandog commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

With Git's default core.quotepath=true, a filename such as docs/使用指南.md is C-quoted in git diff --name-only. The E2E selector treats the quotes and escapes as part of the path, so a documentation-only change can incorrectly trigger all E2E domains.

Changes

  • Request NUL-delimited filenames from Git and split on NUL before applying the existing path normalization.
  • Add a regression test using a real temporary Git repository with Unicode and space-containing filenames.

Test Plan

  • Confirmed the new regression test fails before the implementation change because the Unicode path is escaped and quoted.
  • make script-test passes, including all 166 Node tests and the shell script checks.
  • git diff --check passes.

Related Issues

None.

Summary by CodeRabbit

  • Bug Fixes

    • Improved handling of changed files with spaces, special characters, and Unicode in their names.
    • Preserved accurate file paths during change detection and filtering.
  • Tests

    • Added coverage for quoted Git paths containing spaces and Unicode characters.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cf95fcaf-5606-4ecf-af94-8209fcaf627c

📥 Commits

Reviewing files that changed from the base of the PR and between 39aaf9f and 73b39f7.

📒 Files selected for processing (2)
  • scripts/e2e_domains.js
  • scripts/e2e_domains.test.js

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The change updates Git diff path parsing to use NUL-delimited output. An end-to-end test verifies filenames with Unicode characters and spaces.

Changes

Git path handling

Layer / File(s) Summary
NUL-delimited path collection and validation
scripts/e2e_domains.js, scripts/e2e_domains.test.js
readChangedFiles splits NUL-delimited Git output. The test verifies quoted filenames with Unicode characters and spaces.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 73b39

Unicode and space-containing changed paths are now preserved during E2E domain selection, with regression coverage for the reported behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI fix for Unicode paths in E2E domain selection.
Description check ✅ Passed The description includes all required sections and clearly explains the motivation, implementation, regression test, and verification results. The Test Plan uses prose instead of the template checkbox…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant