fix(ci): handle Unicode paths in E2E domain selection - #2716
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change updates Git diff path parsing to use NUL-delimited output. An end-to-end test verifies filenames with Unicode characters and spaces. ChangesGit path handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Unicode and space-containing changed paths are now preserved during E2E domain selection, with regression coverage for the reported behavior. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
With Git's default
core.quotepath=true, a filename such asdocs/使用指南.mdis C-quoted ingit diff --name-only. The E2E selector treats the quotes and escapes as part of the path, so a documentation-only change can incorrectly trigger all E2E domains.Changes
Test Plan
make script-testpasses, including all 166 Node tests and the shell script checks.git diff --checkpasses.Related Issues
None.
Summary by CodeRabbit
Bug Fixes
Tests