chore: enforce npm min-release-age dependency cooldown - #77
Draft
joker23 wants to merge 3 commits into
Draft
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Supply chain hardening for legacy SDK repositories, mirroring js-core's yarn
npmMinimalAgeGate: 4320(3 days).Describe the solution you've provided
.npmrcwithmin-release-age=3, so npm resolves only versions published more than 3 days ago. Unlike a Dependabot-level setting, this applies to every install — local development and CI alike.npm@^11.9.1beforenpm installso the gate is actually enforced there (earlier npm ignores the config with an "Unknown project config" warning). Because that npm requires node >=20.17, the node 18 matrix entry is raised to node 20 (node 18 is EOL).Describe alternatives you've considered
cooldown: only governs Dependabot PRs, and these legacy repos aren't aiming to stay continuously updated.min-release-age-excludeto exempt LaunchDarkly-owned packages: would let fresh first-party releases through, but npm 12 requires node >=22.22, narrowing the CI matrix further.Additional context
Verified locally:
npm install+ tests pass with the gate active on this branch.Merge order: this depends on the
launchdarkly-js-sdk-common5.8.3 bump (#76) having aged past the cooldown window — CI here will fail until roughly 3 days after that release, so this should land after that point.Link to Devin session: https://app.devin.ai/sessions/566f0d951dfa4568b67ad0c6c1cfb7c1
Requested by: @joker23