Skip to content

feat: Report provider name and version to LaunchDarkly - #30

Merged
kinyoklion merged 3 commits into
mainfrom
devin/ruby-wrapper-info
Aug 21, 2026
Merged

feat: Report provider name and version to LaunchDarkly#30
kinyoklion merged 3 commits into
mainfrom
devin/ruby-wrapper-info

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Aug 19, 2026

Copy link
Copy Markdown
Member

Reports the provider as the wrapper so LaunchDarkly can attribute usage to the OpenFeature Ruby provider rather than the base Ruby SDK.

  • The provider derives its client configuration with Config#with_wrapper_information("open-feature-ruby-server", VERSION), leaving the application's configuration untouched.
  • Requires launchdarkly-server-sdk ~> 8.15, the release that adds Config#with_wrapper_information (feat: Add Config#with_wrapper_information ruby-server-sdk#421). That version is now published, so dependency resolution succeeds.
Implementation details

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Part of an audit of the LaunchDarkly OpenFeature providers against the current OpenFeature specification. The Java and .NET providers already identify themselves via wrapper info; the Ruby provider did not, so usage of this provider was indistinguishable from direct use of the Ruby server SDK.

Describe the solution you've provided

Config exposes wrapper_name/wrapper_version as readers only, so the base SDK gained a supported way to derive a configuration with different wrapper information. The provider calls it when constructing its client.

Describe alternatives you've considered

Setting the configuration's instance variables from the provider — rejected, as the provider must not depend on SDK internals. Rebuilding the configuration from its public readers — rejected because it would silently drop configuration options the provider does not know about.

Testing

bundle exec rake (RSpec + RuboCop) on Ruby 3.4: 55 examples, 0 failures; 12 files inspected, no offenses. CI now resolves against the published 8.15.0 gem.

Link to Devin session: https://app.devin.ai/sessions/0c452d209ec54b068ba120b4c92b8f6c
Requested by: @kinyoklion


Note

Overview
The OpenFeature Ruby provider now identifies itself to LaunchDarkly as wrapper open-feature-ruby-server with the gem VERSION, so usage is attributed to this provider instead of the base Ruby SDK.

On client construction it derives config via Config#with_wrapper_information and leaves the caller’s Config unchanged. Runtime dependency is bumped to launchdarkly-server-sdk ~> 8.15 for that API. A spec asserts wrapper name/version are passed through.

Reviewed by Cursor Bugbot for commit ffac4cf. Bugbot is set up for automated code reviews on this repo. Configure here.

@kinyoklion kinyoklion self-assigned this Aug 19, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot added the devin-pr PRs created by Devin label Aug 19, 2026
@kinyoklion
kinyoklion marked this pull request as ready for review August 20, 2026 21:57
@kinyoklion
kinyoklion requested a review from a team as a code owner August 20, 2026 21:57
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/ruby-wrapper-info branch from 89013eb to 683f283 Compare August 21, 2026 21:42
devin-ai-integration Bot and others added 2 commits August 21, 2026 21:42
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/ruby-wrapper-info branch from 683f283 to 0cbc723 Compare August 21, 2026 21:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0cbc723. Configure here.

Comment thread spec/provider_spec.rb
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion
kinyoklion merged commit c5dd94d into main Aug 21, 2026
8 checks passed
@kinyoklion
kinyoklion deleted the devin/ruby-wrapper-info branch August 21, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PRs created by Devin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants