features/sql: report integrity constraint violations as their own exception - #600
Open
cportele wants to merge 1 commit into
Open
features/sql: report integrity constraint violations as their own exception#600cportele wants to merge 1 commit into
cportele wants to merge 1 commit into
Conversation
…eption A mutation statement rejected by the database in SQLSTATE class 23 — a CHECK or foreign-key constraint, a unique index, or a trigger raising one — is caused by the data the client sent, not by a bug or an infrastructure problem. Every SQLException was wrapped in an IllegalStateException, so callers could not tell the two apart, report the rejection as a client error, or log it without a stack trace. - new FeatureMutationConstraintException, carrying the SQLSTATE - JdbcSqlSession.mutationFailed() picks the exception type from the SQLSTATE and replaces the four wrap sites; anything else stays an IllegalStateException and keeps its stack trace - the SQLSTATE is found by iterating the SQLException itself, which walks the next-exception chain as well as the causal one: executeBatch() reports a BatchUpdateException whose actual error is a next-exception, not a cause
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mutation statement rejected by the database in SQLSTATE class 23 — a CHECK or foreign-key constraint, a unique index, or a trigger raising one — is caused by the data the client sent, not by a bug or an infrastructure problem. Every SQLException was wrapped in an IllegalStateException, so callers could not tell the two apart, report the rejection as a client error, or log it without a stack trace.