Fix cross-compilaton by using PKG_CONFIG env variable#148
Open
onny wants to merge 1 commit into
Open
Conversation
Nikratio
reviewed
Jul 10, 2026
| def pkg_config(pkg, cflags=True, ldflags=False, min_ver=None): | ||
| """Frontend to pkg-config""" | ||
|
|
||
| PKG_CONFIG = os.environ.get('PKG_CONFIG', 'pkg-config').split() |
Author
There was a problem hiding this comment.
as far as i read the PKG_CONFIG variable can hold, in addition to the executable name, also extra command line arguments. splitting it so we could feed the resulting list in subprocess as a command
Contributor
There was a problem hiding this comment.
Oh, I did not expect that. Could you add a comment explaining this (ideally with a link to the place where this env variable is described)?
Collaborator
There was a problem hiding this comment.
if this is about splitting an arbitrary shell command, just splitting by whitespace is not good enough.
rather use this:
Nikratio
requested changes
Jul 10, 2026
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross compilation to RiscV on NixOS failed because the binary name differs to the hardcoded
pkg-configone set in pyfuse3 build utils. This parses PKG_CONFIG env from the system, used by most build systems and otherwise falls back topkg-configif not set.