Conversation
Encode repository-internal paths as UTF-8 instead of filesystem encoding, and normalize to NFC on macOS to match Git's core.precomposeunicode default. status_file now also accepts raw bytes. Add regression tests covering non-ASCII, non-breaking space, NFC/NFD, and raw bytes paths. Fixes #687 Assisted-by: Kimi Code
Route TreeBuilder.insert through pgit_borrow_gitpath (like get/remove) so all three agree on UTF-8 encoding, raw bytes input, and NFC normalization on macOS. Previously insert used the strict "s" format while get/remove used pgit_borrow_gitpath, so on macOS an entry inserted with an NFD name could not be found afterwards. Also switch tree lookups (Tree.__contains__, Tree.__getitem__ and Tree.__truediv__, all via tree_getentry_by_path) from pgit_borrow_fsdefault to pgit_borrow_gitpath, matching the treebuilder. Add regression tests covering NFC, NFD and raw bytes names. Assisted-by: Kimi Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode repository-internal paths as UTF-8 instead of filesystem encoding, and normalize to NFC on macOS to match Git's core.precomposeunicode default. status_file now also accepts raw bytes.
Add regression tests covering non-ASCII, non-breaking space, NFC/NFD, and raw bytes paths.
Related to #687
Assisted-by: Kimi Code