docs(devlog): record the triage gap closure and the review round - #3482
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
intake: hygiene-blocked
|
github-actions
Bot
added
the
documentation
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueNo actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe pull request adds planning documentation for three triage-gap closures. It records commit ChangesTriage gap closure records
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change records completed triage-gap work and close-out references without modifying runtime behavior. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 427b87d6d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Terminal outcome: **DONE**. All three gaps closed on `origin/dev` via PR #3478, | ||
| merged as `3a9c4d297` and ancestry-proven. |
There was a problem hiding this comment.
_plan
This record declares the unit terminal and fully delivered, but the entire unit remains under devlog/_plan, where repository convention reserves entries for open work. Keeping a completed unit there makes plan inventories and future triage treat it as unresolved; move 260904_triage_gap_closure to devlog/_fin as part of this closeout.
AGENTS.md reference: AGENTS.md:L83-L86
Useful? React with 👍 / 👎.
Closes out devlog/_plan/260904_triage_gap_closure with what actually shipped and the landing SHAs: PR #3478 (3a9c4d2) carried all three gaps, and #3293, #3431 and #3429 are closed citing it. The part worth keeping is the review round. The first Ultra Fast implementation passed every suite and was wrong: recognising ultrafast as a canonical marker routed it into decideTier's canonicalToWire lookup, which maps only priority, so an unmapped canonical fell through to drop and the tier stopped reaching the provider — where previously, as a foreign tier, it was forwarded verbatim. Recognition made the reported problem worse. Every listed suite stayed green because they unit-tested the two edited functions in isolation and never asserted the wire decision, and the byte golden pins catalog bytes rather than the caller routing path. Two lessons recorded: a test of the functions you edited is not a test of the behavior you changed, and widening a predicate that serves three questions silently changes the other two. Also records what was deliberately NOT done — Ultra Fast is still absent from the model picker, because upstream advertises only priority and a catalog row would offer a speed the wire cannot deliver, which is what PR #2994 was closed for. This document describes carried work whose code already landed in #3478 with the trailer. Repeating it here keeps the contributor graph correct for a body that names #3293 as carried. Co-authored-by: wj <wj@nas-backup>
427b87d to
679abb6
Compare
github-actions
Bot
removed
the
intake: hygiene-blocked
리뷰 · 우선순위 38 / 80이 PR은 코드가 아니라 기록입니다. 이미 지금 그래도 이 PR만으로는 아직 merge 준비가 아닙니다. 게이트가 draft로 잠가 둔 이유가 있고, CREDITS 인용 주체가 문서와 파일이 서로 다릅니다. 문서만의 PR이라도 “누가 말했는지”가 틀리면 나중에 CREDITS를 읽는 사람이 잘못된 기여자를 따라갑니다. 라인 020_credits_3284.md Close-out Done 줄 - 경로 040_delivery_record.md CREDITS 표 셀 - “quoting @Ingwannu verbatim”도 같은 오류입니다. HEAD의 경로 010_fable_metadata.md - 020·030에는 Landed 배너가 생겼는데 wp1(fable) 쪽 010에는 없습니다. 세 gap이 같은 SHA로 끝났다고 040이 말한다면 010에도 같은 한 줄이 있어야 기록이 균일합니다. 경로 PR 본문·커밋이 #3293을 carry/재구현으로 언급 - hygiene 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
1 participant
Summary
Closes out
devlog/_plan/260904_triage_gap_closurewith what shipped and the landing SHAs. PR #3478 (3a9c4d297) carried all three gaps; #3293, #3431 and #3429 are closed citing it.The part worth keeping is the review round. The first Ultra Fast implementation passed every suite and was wrong: recognising
ultrafastas a canonical marker routed it intodecideTier'scanonicalToWirelookup, which maps onlypriority, so an unmapped canonical fell through todropand the tier stopped reaching the provider — where previously, as a foreign tier, it was forwarded verbatim. Recognition made the reported problem worse.Every listed suite stayed green because they unit-tested the two edited functions in isolation and never asserted the wire decision, and the byte golden pins catalog bytes rather than the caller routing path. Two lessons recorded: a test of the functions you edited is not a test of the behavior you changed, and widening a predicate that serves three questions silently changes the other two.
It also records what was deliberately not done — Ultra Fast is still absent from the model picker, because upstream advertises only
priorityand a catalog row would offer a speed the wire cannot deliver, which is exactly what PR #2994 was closed for.Verification
devlog/, and no component, stylesheet, locale catalog, or runtime file is touched, so there is no rendered change to capture.bun run typecheck,bun run lint:gui, 720 focused tests,bun run test:changedat 14466 pass / 0 fail, and 23 CI checks green on the merged head.Checklist
Devlog prose only — no auth, credential, workflow, or release surface.
Summary by CodeRabbit