Skip to content

fix(routing): evaluate effective provider capabilities and availability - #3694

Merged
lidge-jun merged 9 commits into
devfrom
codex/a-05-capabilities
Sep 5, 2026
Merged

fix(routing): evaluate effective provider capabilities and availability#3694
lidge-jun merged 9 commits into
devfrom
codex/a-05-capabilities

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

Routing policies now evaluate the effective provider used for dispatch. Missing, disabled or unresolvable providers are excluded before scoring under every unknown-evidence policy. Ordinary management dry-run shares runtime evidence; explicit synthetic evidence keeps its simulation semantics.

Carries #3671 with original contributor commits and author metadata retained. Additional regressions cover the exact boundary cases described in the source change. Depends on #3692; review this layer's diff only. Foundation #3708 supplies separately reviewed replay-fixture and bounded Unix cleanup corrections.

Remaining stack (merge bottom-up): #3708#3692#3694. Earlier A layers #3683, #3686 and #3690 are on dev.

Verification

  • Independent implementation/security and final regression reviews passed.
  • Feature-focused remote checks passed before the final foundation refresh, including explicit negative controls. No local suite/typecheck/build executed.
  • Current head: 8647ac2ca28495c85acdf5de48473dd5d4e38119. Full current-head CI: https://github.com/lidge-jun/opencodex/actions/runs/33986934038 . Fresh gates must pass before owner-authorized admin merge.
  • Integrated final-tree remote validation is running. Earlier failed controls remain diagnosis evidence, not green claims.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Co-authored-by: Hako 25837994+devswha@users.noreply.github.com

Final foundation refresh: current head b59a34ce573d1c1dc70b76ef6301324e4ce23b29, full current-head CI https://github.com/lidge-jun/opencodex/actions/runs/33988434944 . Includes the tested direct-management watchdog correction in #3708; feature production code is unchanged by this final refresh.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 5, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

리뷰 · 우선순위 55 / 80

이 PR은 라우팅 policy capability 검사에 실제로 dispatch할 effective provider를 쓰게 합니다. 원본 #3671(Hako) carry입니다. registry transport override·provider-wide reasoning ladder를 반영하고, unresolved/missing/disabled provider는 unknown capability가 허용돼도 scoring 전에 제외합니다. ordinary management dry-run도 같은 evidence assembly를 쓰고, 명시 synthetic dry-run evidence는 기존 의미를 유지합니다. A 스택 맨 위(5층)이고 base는 #3692입니다. 지금 dev에는 아직 없고 단독 머지 불가입니다.

지금 capability 조립이 config.providers[name] + registry name fallback만 보면, 런타임 resolve와 다른 능력치를 보고 고를 수 있습니다. routedProviderConfig 실패를 “known unavailable”로 나누어 permissive unknown 정책이 못 고르게 한 점이 핵심입니다. 가드를 끄면 새 회귀 12개가 깨진다는 검증 서술이 있습니다. 라우팅 가이드·runtime 문서는 이미 동작을 설명한다고 합니다. types/config 분할과 무관합니다.

잘못된 capability로 encrypted task·reasoning ladder를 고르면 런타임에서만 터집니다. policy/dry-run이 같은 증거를 쓰면 운영자가 GUI에서 미리 걸러낼 수 있습니다. Windows verifier(#3696)와 아래 층 CI가 통과하기 전에는 이 층만 초록이어도 안심하기 어렵습니다.

candidateCapabilityEvidence(..., resolvedProvider?) - resolved가 있으면 registry name fallback을 끄고, provider?.reasoningEfforts를 ladder에 포함합니다.

assemblePolicyCandidateEvidence - disabled/missing/resolve throw → route-unavailable exclusion. unknown evidence 허용 정책과 분리합니다.

경로 evaluator route-unavailable - 점수 전에 제외 코드를 붙입니다.

경로 원본 #3671 - 랜딩 후 landed 닫기. draft #3671과 이 replacement를 동시에 열어 두지 마세요.

경로 plan 050_capabilities / 051_capability_refresh - 스택 문서입니다. 리뷰 범위는 effective capability 레이어입니다.

메인테이너의 판단이 필요한 지점

  • dry-run API 응답에 unavailable reason을 더 노출할지
  • Windows verifier(#3696) 없이 이 층 CI를 믿을지
  • #3671을 ready 시점에 미리 닫을지 머지 후에 닫을지

너의 추천
A 스택 맨 위이므로 아래 전 층 + #3696 Windows 초록 후 머지. #3671 landed 닫기. 단독 dev 머지 금지.

이 댓글은 grok-bot이 작성했습니다

lidge-jun added a commit that referenced this pull request Sep 5, 2026
Owner-authorized admin integration of the independently reviewed A stack through #3716.

Exact head: 5097e66. All 24 actual full cross-platform producers succeeded in https://github.com/lidge-jun/opencodex/actions/runs/33991642514. Any queued aggregation-only job is accepted only after directly checking its exact allowlist. No pending or failed functional producer of this integration candidate is waived.

Carries #3708 bounded Unix probe cleanup and deterministic verification, #3692 Command Code conversation affinity (source #3581), and #3694 effective provider capability evaluation (source #3671). Earlier failing foundation jobs remain recorded and are superseded by this fully tested descendant. All lower-layer and contributor commits remain ancestors; original author identities are preserved. After dev ancestry verification, originals and superseded review PRs are closed with the actual landing evidence. Related #3661 remains open.

Co-authored-by: SB Yoon <44089734+yansigit@users.noreply.github.com>
Co-authored-by: Hako <25837994+devswha@users.noreply.github.com>
Base automatically changed from codex/a-04-affinity to dev September 5, 2026 21:45
@lidge-jun
lidge-jun merged commit b59a34c into dev Sep 5, 2026
44 of 54 checks passed
@lidge-jun
lidge-jun deleted the codex/a-05-capabilities branch September 5, 2026 21:45
@lidge-jun

Copy link
Copy Markdown
Owner Author

Integrated as part of the reviewed stack through #3716, dev merge a2f69c8aa60976345740ae6f3d2301f89297328e. This layer's exact head b59a34ce573d1c1dc70b76ef6301324e4ce23b29 is an ancestor of dev. The final descendant passed all 24 actual cross-platform CI producers: https://github.com/lidge-jun/opencodex/actions/runs/33991642514. Historical CI remains recorded; the actual integration candidate is #3716.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants