docs: clarify encrypted combo recovery fallback outcomes - #3763
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change adds a recovery documentation plan and updates English, French, Simplified Chinese, and Traditional Chinese documentation. The text covers native-attempt exhaustion, recovery failure responses, and prevention of unreadable ciphertext forwarding. No runtime code changes are included. ChangesRecovery documentation alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The documentation clarifies encrypted sub-agent recovery after native-target exhaustion and preserves the fail-closed handling of unreadable ciphertext. No runtime behavior changes or merge-blocking risks are identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 384dea7e71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Les chaînes de repli propres à un rôle doivent résider dans la configuration d’opencodex. L’ajout de `model_fallback` dans `$CODEX_HOME/agents/*.toml` amène Codex 0.146+ à rejeter le fichier de rôle entier à cause de ce champ inconnu, puis à ignorer le rôle (#1190). Une ancienne ligne `model_fallback` dans le fichier TOML reste lue par souci de rétrocompatibilité, mais `ocx doctor` la signale. | ||
|
|
||
| opencodex ignore les candidats désactivés, non routables, en mauvais état, en période de temporisation ou ayant atteint le seuil de quota. L’instantané de disponibilité est mis en cache pendant `subagentModelFallbackPollMs`. Les tâches enfants chiffrées limitent la chaîne aux cibles ChatGPT natives canoniques et aux routes Responses directes avec authentification par clé explicitement approuvées via `allowEncryptedV2AgentTasks: true` ; si aucune ne peut consommer la charge chiffrée, la requête échoue au lieu d’envoyer un texte chiffré illisible à une autre destination. Un combo essaie d’abord une cible native canonique disponible ; si aucune n’est sélectionnable et que `agentTaskRecovery` est activé, un `NEW_TASK` chiffré est récupéré une fois avant l’envoi routé du combo. | ||
| opencodex ignore les candidats désactivés, non routables, en mauvais état, en période de temporisation ou ayant atteint le seuil de quota. L’instantané de disponibilité est mis en cache pendant `subagentModelFallbackPollMs`. Les tâches enfants chiffrées limitent la chaîne aux cibles ChatGPT natives canoniques et aux routes Responses directes avec authentification par clé explicitement approuvées via `allowEncryptedV2AgentTasks: true` ; si aucune ne peut consommer la charge chiffrée et que la récupération facultative ne permet pas un envoi routé, la requête échoue sans transmettre de texte chiffré illisible. Un combo essaie d’abord une cible native canonique disponible ; si aucune n’est sélectionnable ou si les tentatives natives sont épuisées, et que `agentTaskRecovery` est activé, un `NEW_TASK` chiffré est récupéré une fois avant l’envoi routé du combo. |
There was a problem hiding this comment.
Update the canonical English reference alongside these translations: this changed paragraph now says recovery may run after native attempts are exhausted, while docs-site/src/content/docs/reference/configuration/agents.md:119-122 still says the request fails when no target can consume the ciphertext and limits recovery to cases where no native target is selectable. As a result, the canonical page documents behavior that conflicts with both the changed translations and the updated English guide.
AGENTS.md reference: docs-site/AGENTS.md:L7-L10
Useful? React with 👍 / 👎.
|
Exact-head Cross-platform CI 34026723367 completed SUCCESS on 384dea7 (docs aggregate ci). After #3762 merge, this PR base is current dev; head preserved with no rebase. Maintainer-integration choice: admin merge into current dev after assert-mergeable-review.sh --maintainer-integration 3763; no branch delete. Codex P2 locale-consistency comment on French agents.md vs English reference is not a runtime/security finding and is not silently resolved here. |
github-actions
Bot
added
the
documentation
1 participant
Summary
Verification
Checklist
Manual dependent PR above #3762. No authentication, credential handling or runtime policy change.
Summary by CodeRabbit
Sidecar verification
Exact-head Cross-platform CI 34026723367 completed SUCCESS on 384dea7 (docs aggregate ci). After #3762 merge, this PR base is current dev; head preserved with no rebase. Maintainer-integration choice: admin merge into current dev after assert-mergeable-review.sh --maintainer-integration 3763; no branch delete. Codex P2 locale-consistency comment on French agents.md vs English reference is not a runtime/security finding and is not silently resolved here.