fix(responses): align Spark Lite metadata with serialized body - #4359
Conversation
Co-authored-by: Eran <earan@localhost> Co-authored-by: yxr1995-maker <257504378+yxr1995-maker@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Wonchang Oh <itismyfield@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Codex <codex@localhost>
Co-authored-by: Robin Bially <7304732+RobinBially@users.noreply.github.com> Co-authored-by: yxr1995-maker <257504378+yxr1995-maker@users.noreply.github.com> Co-authored-by: Eran <earan@localhost>
Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
a5d65fc to
4b8eaed
Compare
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 66 / 80이 PR은 Spark Responses Lite 헤더·WebSocket 메타데이터를, 실제로 직렬화되는 body 모양에 맞춥니다. body에 비어 있지 않은 버그의 실체는 이렇습니다. Spark 카탈로그는 도구를 top-level 코드 변경의 중심은 라인 / 심볼 - 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Carry #4319 with native raw-ladder distinction and regression coverage. Co-authored-by: Keito Itagaki <171206780+ke-1t@users.noreply.github.com>
Document reasoningEffortMode in all seven translated guides. Keep the original Chat-wire regression; Responses summary is not a Chat request field.
Resolve structure/ doc conflicts by keeping both the combos reasoning-preservation notes and the dev service_tier echo contract.
Keep both the Console upload-rejection exclusion note and the inherited responses-transport contract paragraphs.
Keep both the raw-reasoning presentation note and the combo effort-normalization note in the Cursor provider doc.
All conflicts were add/add doc paragraphs from the hint and thinking lanes at the same anchor; both notes are retained.
Add/add doc conflicts keep both the Spark Lite metadata note and the inherited transport-hint and summary contracts.
⏳ DRAFT
What to do
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
Summary
Derive canonical Spark Responses Lite headers and WebSocket metadata from the body actually serialized. A surviving nonempty
additional_tools.toolsarray pins Lite totrue; other Spark bodies pin it tofalse. Header casing, stale native metadata, aliases and configured bracket-suffix removal use the final wire model. Other models and noncanonical configured headers retain their policy.Carries #4130 with its latest bidirectional body-shape correction and resolves the remaining empty-group documentation finding across eight locales. Adds post-filter catalog, reserved-functions, top-level-tools, bracket normalization and noncanonical header coverage alongside the author's socket-retirement/reuse tests. This proves the intended framing contract once CI passes; it does not claim a live provider EOF fix.
Spark remains available. #4334 retirement is a separate HOLD and is not included. No running service or user configuration was changed. Independent ordinary dev-based PR; source PR disposition after integration belongs to the coordinator.
Verification
--no-verify.git diff --checkand the documentation/source-map validatorbun scripts/structure-ssot.ts: passed. These are source checks, not product tests.Checklist
Co-authored-by: luvs01 27862058+luvs01@users.noreply.github.com
Current head:
4b8eaed3449b4e10dd67aefd0b6e9b0bfe06005e, rebased ontoe4ee8c54b0d3dcf5d245aea4589d608bf118c9c3. Independent implementation/security and resolution-only audits PASS; adapter, transport dependencies and both tests byte-identical to reviewed product commit. Source credits retained. Local product checks NOT RUN; refreshed hosted CI pending.