Revert "feat(usage): show the cached subset beside every token total" - #4424
Conversation
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
💤 Files with no reviewable changes (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change removes cached-token formatting from GUI and CLI usage views. It removes related fields, helpers, imports, tests, and test-layout mappings. Usage displays now show aggregate token totals only. ChangesUsage token display
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~15 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change removes cached-token details while preserving aggregate usage totals and their existing display paths. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 76 / 80이 PR은 방금 gui/src/pages/Logs.tsx (대화 합계 배너) - revert 후 배너는 다시 gui/src/pages/Usage.tsx · dashboard-overview-head.tsx · src/cli/usage-report.ts - 캐시 필드 타입과 동반 표기가 빠집니다. #4419 이후 Devin 데이터가 채워져도 Usage/CLI는 총량만 보입니다. “원래 의도한 표면”으로 되돌리는 것이면 맞고, 동반 표기를 제품 기능으로 남기고 싶다면 별 PR로 다시 설계해야 합니다. devlog/_plan/260912_devin_hardening/cached-token-companion.jpg - plan 증거 이미지도 삭제됩니다. 계획 폴더 정리와 맞으면 문제 없습니다. enforce-target (CI) - tests/gui/gui-format-tokens-cache.test.ts · layout.json - 테스트와 layout 등록도 같이 빠져 정합합니다. 로컬로 지정한 usage-report·layout 테스트는 통과했다고 본문에 적혀 있고, 원격 test shard는 이 글을 쓰는 순간 아직 pending입니다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
This reverts 7b3c4e9. The reported defect was Devin-only and had nothing to do with the display layer. The logs table has always rendered a total with its cached value; Devin rows showed a bare total because the cloud-direct adapter decoded GetChatMessageResponse field 28 (response_dimension_groups, the rows the IDE draws) instead of field 7 (ModelUsageStats), so cache read and cache write never reached the log row in the first place. #4419 fixes that at the source, which is the whole fix. Changing the Usage page, the dashboard tile and the CLI tables rewrote surfaces that were already correct for every other provider, so the revert restores them.
b97a72b to
3c3cf42
Compare
Summary
Reverts #4421 (
7b3c4e9800).The reported defect was Devin-only and did not live in the display layer. The logs table has always rendered a token total with its cached value beneath it; Devin rows showed a bare total because the cloud-direct adapter decoded
GetChatMessageResponsefield 28 —response_dimension_groups, the rows the IDE draws — instead of field 7,ModelUsageStats. Cache read and cache write never reached the log row at all, so there was nothing for the renderer to show.#4419 fixes that at the source, and that is the whole fix. Every other provider was already correct.
#4421 instead rewrote the Usage page columns, the dashboard 30-day tile and the CLI usage tables, which were behaving as intended. This revert restores them.
The screenshot is the point of the revert: the layout is exactly what it was before #4421, and the two Devin CLI rows now carry
c 4만andc 5.7만— which they could not before #4419, and which no display change was ever needed to produce. Captured from a build of this branch on a throwaway proxy with its own port andOPENCODEX_HOME.Verification
bun x tsc --noEmit— clean.bun run lint:gui— clean.bun test tests/cli/cli-usage-report.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts— 51 pass, 0 fail; the layout guards confirm the removed test file is deregistered.bun run test: NOT RUN locally by request; remote CI on this head is the evidence.Checklist