Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueNo actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (15)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change adds image-input metadata to Anthropic model seeds, propagates it through the catalog, exports it in supported client formats, and adds registry, catalog, discovery, and management-route coverage for both Anthropic authentication modes. ChangesAnthropic capability metadata
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant AnthropicProvider
participant ModelCatalog
participant ConfigExporters
AnthropicProvider->>ModelCatalog: declare text and image modalities
ModelCatalog->>ConfigExporters: provide input modalities
ConfigExporters-->>AnthropicProvider: emit client-specific capability fields
Merge Risk: ⚪ Minimal · up to The capability metadata and supported client exports are covered for both Anthropic authentication modes, including override and unknown-model behavior. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 9 files. (6 skipped: 6 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
1/4 boxes ticked. This PR stays in draft until every box above is ticked. |
리뷰 · 우선순위 67 / 80이 PR은 초안(draft) 이고, 이슈 #4667을 닫으려는 카탈로그·익스포터 버그 수정이다. 지금 고침은 세 층이다. 첫째, 회귀는 넓다. 레지스트리 패리티, OpenClaw/Kimi 단위, management 경로에서 capability-aware 익스포터 14종(Aside/Pi/Prime/omo/OMP/GJC/DSH/OpenCode/ZCode/Cline/Hermes/Raycast/OpenClaw/Kimi), Codex types.ts / config.ts 모놀리스 본문을 고치지 않는다. close-don't-rebase 대상이 아니다. #3474·#3454·#4497/#4534 와 겹치는 “다른 층”을 PR 본문이 잘 구분했다. 다만 작성자가 스스로 full-suite/local-CI 초록을 주장하지 않았다. bubblewrap 권한 실패 2건은 이 PR과 무관해 보이고, 라인 / 경로 수준 주의 포인트:
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Missing modelInputModalities on both Anthropic registry entries caused Aside, Pi and GJC exports to fall back to text-only input. Seed the known Claude models once and preserve explicit operator overrides through existing enrichment. Add registry and production catalog-to-client regression coverage for both auth flows. Update provider documentation and mapped architecture notes. Refs lidge-jun#4667
Preserve declared OpenClaw input modalities and emit Kimi image_in capabilities instead of losing catalog-backed vision support. Keep unknown-model defaults and schemas without an established capability field unchanged. Cover all 14 capability-aware config exporters and the Codex/Claude catalog surfaces from both Anthropic auth-provider seeds. Record the complete integration scope in the docs. Refs lidge-jun#4667 Co-authored-by: Theo / Taeyoon Kang <kang3603a@gmail.com>
a9b3654 to
24adf12
Compare
Summary
Closes #4667
Fix image-input capability loss across integration configurations, not only the initially reported Aside/Pi/GJC examples.
modelInputModalitiesfor the nine known Claude model seeds to bothanthropicandanthropic-apikey. Missing source metadata previously triggered text-only/unknown export defaults; existing per-model overrides remain authoritative.input; Kimi CLI emitscapabilities: ["image_in"]for catalog-backed image input. These exporter fixes apply to any declared image-capable model, not just Anthropic.input_modalitiesand Claude discoverycapabilities.image_input.supported, including Desktop/readable aliases and[1m]variants, for both Anthropic auth flows.Scope and evidence boundary
All 15 registered exporters and the additional Codex/Claude/MMX surfaces were audited. The remaining registered exporter, MiniMax Code, exposes no image field in the current local contract, and an authoritative upstream field could not be established; no unsupported field was invented. Connection-only/cache shapes (Claude gateway cache, Desktop static config, MMX launcher) are unchanged. This is not a blanket claim that every application supports images or that every future/date-pinned Claude alias has verified metadata.
Official references: Claude models, OpenClaw schema, OpenClaw text-only default, Kimi capabilities.
Related prior work: #3474 fixed combo metadata; #3454 fixed Anthropic reasoning advertisement; #4497/#4534 fixed image wire handling. None replaced this cross-integration capability audit.
Verification
input: ["text"]; registry assertion returnedundefined. OpenClaw and Kimi each separately failed for missing supported capability fields after the registry fix.bun run typecheck,bun run privacy:scan,bun run structure:check,git diff --check;cd docs-site && bun install --frozen-lockfile && bun run build— 441 pages (nonblocking build warnings).bun test tests/config tests/clients tests/integrations— 1178 pass, 3 skip, 2 fail. Both failures are in unchangedremote-workspace-command-runner.test.ts: the local Bun executable/ancestor path failsbubblewrap executable and parent directories must not be group or world writable. Reproduced independently; no trust check weakened.bun run test:changedselected 965 files but a Bun 1.4.2 parallel worker crashed withSIGSEGVinrouting-policy-surface-parity.test.ts, aborting the remaining files. That file alone passed (6 tests). The--parallel=1retry produced no test progress for several minutes and was stopped. Full-suite/local-CI green is not claimed.Checklist
No authentication, credentials, routing or image-wire behavior changed; privacy scan passed. Submitted as draft per contributor policy and because broad validation is not fully green.
Review readiness
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
New Features
Documentation