Skip to content

fix(claude): retain committed gateway state after cleanup failure - #5519

Merged
lidge-jun merged 1 commit into
devfrom
codex/native-tray-gateway-bookkeeping
Sep 22, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/native-tray-gateway-bookkeeping

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

  • Persist the committed Claude Desktop gateway mode, profile fingerprint and timestamp together before retiring first-party settings. Cleanup failure still returns a partial failure, while later status/default apply keeps the gateway choice.
  • Update both the durable state and the reused management snapshot; preserve CLI lifecycle/config locking. Add API, native-toggle and CLI regression cases for malformed settings after a real gateway write.
  • Addresses the post-commit bookkeeping finding from feat(desktop): native macOS usage panel and release regression fixes #5490 (review comment 4070117466). Release planning records the owner-requested integration and provisional promotion PRs.

Verification

  • Explicit Sol source and credential-boundary security review: PASS after fixing the native snapshot mirror. No credentials are returned or logged.
  • Local tests/typechecks/builds/QA: NOT RUN by explicit user instruction. New regression cases are committed for hosted CI; execution results are pending.
  • The owner explicitly instructed immediate dev integration without waiting for CI. This is maintainer/admin integration, not an independent approving review or a claim that pending checks passed.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 22, 2026 09:57
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: df74a264-313c-41a1-80fa-b370746c490b

📥 Commits

Reviewing files that changed from the base of the PR and between 6c2f767 and 0e7ed63.

📒 Files selected for processing (8)
  • devlog/_plan/260922_native_tray_release/040_release.md
  • docs-site/src/content/docs/guides/claude-code.md
  • src/claude/desktop-gateway-state.ts
  • src/cli/claude-desktop.ts
  • src/server/management/agent-settings-routes.ts
  • src/server/management/native-integration-routes.ts
  • structure/clients/claude-desktop.md
  • tests/claude-integration/claude-desktop-first-party.test.ts
 ___________________________________________________________________________________________________
< Test your software, or your users will. Test ruthlessly. Don't make your users find bugs for you. >
 ---------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant