fix: release Windows ACL temp-path memos - #840
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Maintainer triage: this is a valuable focused fix. It removes the confirmed Windows process-lifetime temp-path memo leak while preserving fail-closed handling when a residual file remains, and the focused coverage is broad across the affected write paths. The branch currently conflicts with |
Summary
Part of #820. This intentionally extracts the confirmed Windows leak into a focused change instead of coupling it to #829.
Verification
bun run typecheckbun run privacy:scanbun test tests/windows-secret-acl.test.ts tests/config.test.ts tests/server-management-auth.test.ts tests/windows-tray.test.ts(167 pass)react,react/jsx-dev-runtime)Compatibility
Stable destination/directory memo behavior and fail-closed ACL policy are unchanged. Only one-shot temp path entries are released after rename/unlink or proven
ENOENT.