feat(openapi): add CardTransaction to TransactionOneOf for the transaction list#621
Closed
ls-bolt[bot] wants to merge 1 commit into
Closed
feat(openapi): add CardTransaction to TransactionOneOf for the transaction list#621ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
github-actions
Bot
added
the
breaking-change
Contributor
|
Contributor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
✱ Stainless preview builds for gridThis PR will update the cli csharp go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-cli studio · code · diff
✅ grid-python studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-go studio · code · diff
✅ grid-csharp studio · code · diff
✅ grid-php studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-typescript studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
…ction list
Add CardTransaction as a third TransactionOneOf member with a CARD discriminator
so card transactions appear in GET /transactions and deserialize cleanly via the
discriminator. Add a type: CARD discriminator property to CardTransaction and
relax cardId / pullSummary / refundSummary / settlementSummary to optional so the
served card-transaction shape (the GET /transactions/{id} projection) validates.
Document on the list endpoint that card transactions are identified by type: CARD
and that this is how integrators discover a CardTransaction id in Sandbox.
ls-bolt
Bot
force-pushed
the
06-25-grid-card-txn-in-transaction-oneof
branch
from
3edcf11 to
4db282d
Compare
benwgold
added a commit
that referenced
this pull request
Jun 27, 2026
…ction list (#622) ## Summary (draft / PoC — PR 2 of 2 spec change) Adds `CardTransaction` as a third `TransactionOneOf` member with a `CARD` discriminator so card transactions appear in `GET /transactions` and deserialize cleanly via the discriminator. This is the canonical spec change behind the Lightspark webdev SDK regen + sparkcore handler change (the companion PR) that unblocks the documented Grid sandbox card loop (simulate auth → list → simulate clearing → simulate return): integrators discover the `cardTransactionId` from the public transaction list instead of needing the internal dashboard. ### Changes - `TransactionOneOf`: add `CardTransaction` + `CARD` discriminator mapping. - `CardTransaction`: add a `type: CARD` discriminator property; relax `cardId`, `pullSummary`, `refundSummary`, `settlementSummary` to optional so the served card-transaction shape (the `GET /transactions/{id}` projection) validates and the list deserializes cleanly even for card transactions without a resolved card. - `GET /transactions`: document that card transactions are identified by `type: CARD` and that this is how integrators discover a `CardTransaction` id in Sandbox. The bundled `openapi.yaml` / `mintlify/openapi.yaml` carry only this change (the redocly rebundle reorders unrelated schemas, so the diff is scoped to the actual change; run `make build` on merge to fully re-normalize). ### Known limitations (PoC) - The served card payload uses `processorTransactionToken`; the schema exposes `issuerTransactionToken`. SDK deserialization still succeeds (the loop works via `id`), but the token isn't surfaced under the typed field — flagged for a follow-up rename. - `GET /transactions?type=CARD` is not yet a valid filter (`TransactionType` is `INCOMING`/`OUTGOING`); clients filter client-side on `type: CARD`. Follow-up. --- 🤖 [arcing-fulcrum](https://zeus.dev.dev.sparkinfra.net/#/arc?id=arcing-fulcrum)[(#1)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=arcing-fulcrum) | [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback) Original PR: #621 --------- Co-authored-by: Bolt Agent <bolt@lightspark.com> Co-authored-by: greptile-apps[bot] <greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (draft / PoC — PR 2 of 2 spec change)
Adds
CardTransactionas a thirdTransactionOneOfmember with aCARDdiscriminator so card transactions appear inGET /transactionsand deserialize cleanly via the discriminator. This is the canonical spec change behind the Lightspark webdev SDK regen + sparkcore handler change (the companion PR) that unblocks the documented Grid sandbox card loop (simulate auth → list → simulate clearing → simulate return): integrators discover thecardTransactionIdfrom the public transaction list instead of needing the internal dashboard.Changes
TransactionOneOf: addCardTransaction+CARDdiscriminator mapping.CardTransaction: add atype: CARDdiscriminator property; relaxcardId,pullSummary,refundSummary,settlementSummaryto optional so the served card-transaction shape (theGET /transactions/{id}projection) validates and the list deserializes cleanly even for card transactions without a resolved card.GET /transactions: document that card transactions are identified bytype: CARDand that this is how integrators discover aCardTransactionid in Sandbox.The bundled
openapi.yaml/mintlify/openapi.yamlcarry only this change (the redocly rebundle reorders unrelated schemas, so the diff is scoped to the actual change; runmake buildon merge to fully re-normalize).Known limitations (PoC)
processorTransactionToken; the schema exposesissuerTransactionToken. SDK deserialization still succeeds (the loop works viaid), but the token isn't surfaced under the typed field — flagged for a follow-up rename.GET /transactions?type=CARDis not yet a valid filter (TransactionTypeisINCOMING/OUTGOING); clients filter client-side ontype: CARD. Follow-up.🤖 arcing-fulcrum(#1) | Feedback