LCORE-2860: RHOAI Prow e2e tests fail to start — service pods never become ready#2050
LCORE-2860: RHOAI Prow e2e tests fail to start — service pods never become ready#2050are-ces wants to merge 4 commits into
Conversation
Remove --image flag from oc new-build that was overriding the containerfile's FROM (ubi9/python-312) with ubi-minimal, which lacks dnf. Remove duplicate vector_stores and embedding model registration from run.yaml since the lightspeed-stack enrichment script handles both. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughModifies the RHOAI e2e test configuration to remove an embedding model and FAISS vector store registration, replacing it with an empty vector store list, and removes an explicit base image argument from the pipeline's build step. ChangesE2E RHOAI Test Config and Pipeline Updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ults The generic lightspeed-stack.yaml uses default_model=gpt-4o-mini and default_provider=openai, which don't exist in the RHOAI environment. This caused 500/404 errors in tests that rely on default model resolution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Create vllm-model-secret from MODEL_NAME in pipeline.sh so both llama-stack and lightspeed-stack pods read the model from a single source instead of hardcoding it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When E2E_DEFAULT_MODEL_OVERRIDE or E2E_DEFAULT_PROVIDER_OVERRIDE env vars are set, patch default_model/default_provider in every config applied via update_config_configmap. This ensures tests that swap to configs like lightspeed-stack-auth-noop-token.yaml use the correct model for the environment instead of hardcoded gpt-4o-mini. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Fix two issues preventing RHOAI Prow e2e pipeline from deploying service pods:
Image build failure (
DockerBuildFailed):oc new-build --image=ubi9/ubi-minimaloverrode the containerfile'sFROM ubi9/python-312withubi-minimal, which lacksdnf. Removed the--imageflag so the containerfile's own base image is used.Vector store registration conflict:
run.yamlpre-registered the vector store and embedding model underprovider_id: faiss, conflicting with the lightspeed-stack enrichment script which registers them underprovider_id: byok_e2e-test-docs. Removed the duplicate entries since enrichment handles both.Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
ubi9/python-312base/v1/querySummary by CodeRabbit