docs(agent-standards): merge four-provider contract updates#1157
Conversation
…#1148) The issue-field automation was a silent no-op because derive-project-fields.cjs emits Priority values (Critical, Important, Normal, Minor) that did not exist in organization_issue_fields.field_usage.Priority.values (was: Urgent, High, Medium, Low). This mismatch meant every Priority write landed empty. Changes: 1. Align Priority.values in issue-fields.yml to the canonical set used by project_field_mappings.Priority, labels.yml, and derive defaults. 2. Add field-parity regression test: asserts that every Status/Priority/Type/ Effort value the automation emits is a declared option. Catches this class of bug (vocabulary drift) without touching the architecture. 3. Update docs/ISSUE_FIELDS.md to match canonical vocabulary. Test coverage: 202/202 passing (18 suites). Parity test fails with old vocabulary, passes with fix — proven effective. Issue: #1133 (standup) Refs: #1134 (yaml.safeLoad deprecation), #1135 (footer validation bugs) Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Add comprehensive planning documentation for bulk project creation system with template-driven field initialization. Includes: - INDEX.md: Project overview and navigation - PLANNING.md: Full architectural blueprint with field mappings, CSV schema, agent and workflow design, implementation roadmap - SUMMARY.md: Quick overview and GitHub issue creation guide - ISSUES.md: Copy-paste ready Epic and Story issue templates Two template types planned: 1. Client Delivery (Scrumban + UAT): Status Backlog→Todo→Done, 9 views 2. Product Development (Release Train): Status Backlog→Ready→Done, 8 views Shared fields across both templates (14 core): Priority, Type, Effort, Area, Theme, Size, Dates, Milestone, Environment, Parent Issue, Sub-issues Progress, Time Implementation: 4 phases, 3–4 weeks, 4–5 developers - Phase 1: Foundations (CSV schema, agent scaffold, workflow) - Phase 2: Client Delivery template (1–2 weeks, parallel) - Phase 3: Product Development template (1–2 weeks, parallel) - Phase 4: PR Type syncing + docs (1 week) Depends on: #1145 (org issue-field writer), #1146 (secret-gating) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…lot, Codex, Gemini) PLUGINS_INTEGRATION_GUIDE.md: - Add codex-manifest.json and gemini-manifest.json to provider-manifests structure - Update README.md capabilities matrix to include all 5 providers - Update INSTALL.md instructions to cover all 5 providers - Expand provider-manifests section with Codex and Gemini configurations - Update package.json keywords to include all 5 providers - Update validation checklist to verify 5 manifests instead of 3 INFRASTRUCTURE_HOOKS_TOOLS_WORKFLOWS.md: - Update agent validation hook checklist to include agent-only provider configs (claude/, copilot/, codex/, gemini/) INSTRUCTIONS_DOCUMENTATION_GUIDE.md: - Update agent instructions frontmatter to include all 5 providers - Update README enhancements to mention all 5 providers - Expand quick-start guide template to include Codex and Gemini setup - Update checklist to require 5 provider quick-starts instead of 3 WEBSITE_CATALOGUE_UPDATES.md: - Add Codex and Gemini sections to "By Provider" learning page structure - Update implementation prompt to include all 5 providers - Update catalogue structure for 5 provider-specific guides PHASE_2_EXECUTION_PLAYBOOK.md: - Update provider intent section to include Claude, Codex, Copilot, Gemini, and OpenAI PROMPT_BATCH_2_TOUR_OPERATOR_CONFIG_AGENT.md: - Add plugin package directory checklist requirement to success criteria PROMPT_BATCH_2_WP_CONFIG_AGENT.md: - Add plugin package directory checklist requirement to success criteria PROMPT_BATCH_2_AGENTS_5_14.md: - Add all 10 agent plugin packages checklist requirement to success criteria Four-provider contract now established across all documentation. All future agents will target Claude, Copilot, Codex, Gemini, and OpenAI with consistent plugin structure, quick-start guides, and validation requirements. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚫 This PR description is missing required template content. Missing required section(s): Linked issues, Changelog, Global DoD checklist Please update the PR body using one of the repository PR templates:
Empty placeholders, unchecked checklist boxes, and stub issue references do not count. |
…t updates Resolves conflicts by accepting four-provider updates (Claude, Copilot, Codex, Gemini, OpenAI) across all documentation files and batch prompts.
20f9746
into
docs/agent-standards-phase-2-prompts
💡 Codex ReviewWhen contributors follow this template, the resulting plugin cannot pass These navigation links are broken because a repo-wide file search finds neither .github/.github/projects/active/github-projects-creation-system/PLANNING.md Lines 270 to 272 in 9e01bfc The no-label PR scenario described as missing is already implemented: The same document enumerates one Phase 1 agent plus thirteen Phase 2 agents—fourteen total—but this implementation instruction and the completion checklist require fifteen. That makes the task's acceptance criterion impossible or encourages inventing an unintended extra catalogue entry; use fourteen consistently unless a fifteenth agent is explicitly added to the scope. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…execution playbook (#1144) * docs(agent-standards): refine Phase 2 prompts into per-chat briefs + add execution playbook - Add PHASE_2_EXECUTION_PLAYBOOK.md (shared execution guide: real-content requirements + verification, the pre-existing develop CI blockers and fixes, commit/push mechanics, PR-body template, merge protocol) - Rewrite the four PROMPT_BATCH_2_* prompts as self-contained per-chat briefs carrying branch, PR, and related issue(s) - Update PHASE_2_BATCH_PROMPTS_INDEX.md with a live branch/PR/issue mapping - Sync package-lock.json and document the 50 limits in docs/ISSUE_FIELDS.md so pre-existing CI checks pass Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(agent-standards): add comprehensive Phase 2 prompt guides Introduce 6 structured per-agent execution guides covering full 7-step workflow: - AGENT_COMPLETE_WORKFLOW.md: 7-step agent development cycle - PLUGINS_INTEGRATION_GUIDE.md: Plugin wrapper creation & validation - INFRASTRUCTURE_HOOKS_TOOLS_WORKFLOWS.md: Hooks, CLI tools, GitHub Actions - INSTRUCTIONS_DOCUMENTATION_GUIDE.md: Agent instructions & documentation - STARTER_PROMPTS_GUIDE.md: 5-8 copy-paste-ready prompts per agent - WEBSITE_CATALOGUE_UPDATES.md: Website updates for agent discovery These guides standardize Phase 2 agent delivery, replacing ad-hoc per-PR guidance with a repeatable, verifiable framework. Each guide includes: - Real-content requirements (line-count floors, validation criteria) - Template prompts ready for dedicated chats - Implementation checklists - Reference implementations (Phase 1 examples) Intended workflow: one agent completes full 7-step cycle before next agent starts. First agent (Tour Operator or Woo Config) uses these guides as executable specification. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix: update playbook filename references to match actual files - AGENT_COMPLETE_WORKFLOW.md: reference PHASE_2_EXECUTION_PLAYBOOK.md (line 7) - WEBSITE_CATALOGUE_UPDATES.md: reference actual playbook filename (lines 154, 211) - Added PHASE_2_BATCH_PROMPTS_INDEX.md to documentation index Ensures all cross-references point to correct filenames on disk. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * docs(agent-standards): resolve code-review findings and standardize execution - AGENT_COMPLETE_WORKFLOW.md: add explicit 'git checkout develop && git pull' before each layer branch to ensure fresh bases and prevent stale commits - INFRASTRUCTURE_HOOKS_TOOLS_WORKFLOWS.md: resolve sequential vs parallel contradiction; require sequential execution (hooks → tools → workflows) with explicit dependency on merged components - PHASE_2_EXECUTION_PLAYBOOK.md: - Update changelog contract to require PR + issue links in [Unreleased] entries - Update git commit command to include Co-Authored-By trailer via HEREDOC - Expand "Linked issues" section to support batch PRs (10+ issues) - Require CI green with no exceptions (footers handled before final gate) - PROMPT_BATCH_2_WOO_CONFIG_AGENT.md: update PCI DSS guidance to require assessment of actual architecture rather than presenting SAQ A/A-EP as defaults - CHANGELOG.md: add PR #1144 link to [Unreleased] Phase 2 playbook entry Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * docs(agent-standards): fix guide references and cardinalities - AGENT_COMPLETE_WORKFLOW.md: correct all guide filename references to actual files - PLUGINS_INTEGRATION_GUIDE.md (was PLUGINS_COMPLETE.md) - INFRASTRUCTURE_HOOKS_TOOLS_WORKFLOWS.md (was INFRASTRUCTURE_HOOKS_TOOLS.md) - INSTRUCTIONS_DOCUMENTATION_GUIDE.md (was INSTRUCTIONS_DOCUMENTATION.md) - PHASE_2_EXECUTION_PLAYBOOK.md: - Fix npm ci --dry-run verification to not mask exit status (use tee + separate grep) - Clarify validate:footers checks only PR diff (--changed-only), not pre-existing repo violations - Remove instruction to repair all 315 violations (risk of body truncation, unrelated file changes) - WEBSITE_CATALOGUE_UPDATES.md: reconcile agent/plugin/hook cardinalities - Agents: 14 total (1 Phase 1 + 3 Phase 2 single + 10 Batch) - Plugins: 14 total (1 core + 13 agent-specific) - Hooks: 17 total (4 core + 13 agent-specific) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * docs: Add GitHub Projects creation system planning documentation Add comprehensive planning documentation for bulk project creation system with template-driven field initialization. Includes: - INDEX.md: Project overview and navigation - PLANNING.md: Full architectural blueprint with field mappings, CSV schema, agent and workflow design, implementation roadmap - SUMMARY.md: Quick overview and GitHub issue creation guide - ISSUES.md: Copy-paste ready Epic and Story issue templates Two template types planned: 1. Client Delivery (Scrumban + UAT): Status Backlog→Todo→Done, 9 views 2. Product Development (Release Train): Status Backlog→Ready→Done, 8 views Shared fields across both templates (14 core): Priority, Type, Effort, Area, Theme, Size, Dates, Milestone, Environment, Parent Issue, Sub-issues Progress, Time Implementation: 4 phases, 3–4 weeks, 4–5 developers - Phase 1: Foundations (CSV schema, agent scaffold, workflow) - Phase 2: Client Delivery template (1–2 weeks, parallel) - Phase 3: Product Development template (1–2 weeks, parallel) - Phase 4: PR Type syncing + docs (1 week) Depends on: #1145 (org issue-field writer), #1146 (secret-gating) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * docs(agent-standards): expand to four-provider contract (Claude, Copilot, Codex, Gemini) PLUGINS_INTEGRATION_GUIDE.md: - Add codex-manifest.json and gemini-manifest.json to provider-manifests structure - Update README.md capabilities matrix to include all 5 providers - Update INSTALL.md instructions to cover all 5 providers - Expand provider-manifests section with Codex and Gemini configurations - Update package.json keywords to include all 5 providers - Update validation checklist to verify 5 manifests instead of 3 INFRASTRUCTURE_HOOKS_TOOLS_WORKFLOWS.md: - Update agent validation hook checklist to include agent-only provider configs (claude/, copilot/, codex/, gemini/) INSTRUCTIONS_DOCUMENTATION_GUIDE.md: - Update agent instructions frontmatter to include all 5 providers - Update README enhancements to mention all 5 providers - Expand quick-start guide template to include Codex and Gemini setup - Update checklist to require 5 provider quick-starts instead of 3 WEBSITE_CATALOGUE_UPDATES.md: - Add Codex and Gemini sections to "By Provider" learning page structure - Update implementation prompt to include all 5 providers - Update catalogue structure for 5 provider-specific guides PHASE_2_EXECUTION_PLAYBOOK.md: - Update provider intent section to include Claude, Codex, Copilot, Gemini, and OpenAI PROMPT_BATCH_2_TOUR_OPERATOR_CONFIG_AGENT.md: - Add plugin package directory checklist requirement to success criteria PROMPT_BATCH_2_WP_CONFIG_AGENT.md: - Add plugin package directory checklist requirement to success criteria PROMPT_BATCH_2_AGENTS_5_14.md: - Add all 10 agent plugin packages checklist requirement to success criteria Four-provider contract now established across all documentation. All future agents will target Claude, Copilot, Codex, Gemini, and OpenAI with consistent plugin structure, quick-start guides, and validation requirements. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * docs(agent-standards): merge four-provider contract updates (#1157) * fix: reconcile Priority field vocabulary + add parity regression test (#1148) The issue-field automation was a silent no-op because derive-project-fields.cjs emits Priority values (Critical, Important, Normal, Minor) that did not exist in organization_issue_fields.field_usage.Priority.values (was: Urgent, High, Medium, Low). This mismatch meant every Priority write landed empty. Changes: 1. Align Priority.values in issue-fields.yml to the canonical set used by project_field_mappings.Priority, labels.yml, and derive defaults. 2. Add field-parity regression test: asserts that every Status/Priority/Type/ Effort value the automation emits is a declared option. Catches this class of bug (vocabulary drift) without touching the architecture. 3. Update docs/ISSUE_FIELDS.md to match canonical vocabulary. Test coverage: 202/202 passing (18 suites). Parity test fails with old vocabulary, passes with fix — proven effective. Issue: #1133 (standup) Refs: #1134 (yaml.safeLoad deprecation), #1135 (footer validation bugs) Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com> * docs: Add GitHub Projects creation system planning documentation Add comprehensive planning documentation for bulk project creation system with template-driven field initialization. Includes: - INDEX.md: Project overview and navigation - PLANNING.md: Full architectural blueprint with field mappings, CSV schema, agent and workflow design, implementation roadmap - SUMMARY.md: Quick overview and GitHub issue creation guide - ISSUES.md: Copy-paste ready Epic and Story issue templates Two template types planned: 1. Client Delivery (Scrumban + UAT): Status Backlog→Todo→Done, 9 views 2. Product Development (Release Train): Status Backlog→Ready→Done, 8 views Shared fields across both templates (14 core): Priority, Type, Effort, Area, Theme, Size, Dates, Milestone, Environment, Parent Issue, Sub-issues Progress, Time Implementation: 4 phases, 3–4 weeks, 4–5 developers - Phase 1: Foundations (CSV schema, agent scaffold, workflow) - Phase 2: Client Delivery template (1–2 weeks, parallel) - Phase 3: Product Development template (1–2 weeks, parallel) - Phase 4: PR Type syncing + docs (1 week) Depends on: #1145 (org issue-field writer), #1146 (secret-gating) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * docs(agent-standards): expand to four-provider contract (Claude, Copilot, Codex, Gemini) PLUGINS_INTEGRATION_GUIDE.md: - Add codex-manifest.json and gemini-manifest.json to provider-manifests structure - Update README.md capabilities matrix to include all 5 providers - Update INSTALL.md instructions to cover all 5 providers - Expand provider-manifests section with Codex and Gemini configurations - Update package.json keywords to include all 5 providers - Update validation checklist to verify 5 manifests instead of 3 INFRASTRUCTURE_HOOKS_TOOLS_WORKFLOWS.md: - Update agent validation hook checklist to include agent-only provider configs (claude/, copilot/, codex/, gemini/) INSTRUCTIONS_DOCUMENTATION_GUIDE.md: - Update agent instructions frontmatter to include all 5 providers - Update README enhancements to mention all 5 providers - Expand quick-start guide template to include Codex and Gemini setup - Update checklist to require 5 provider quick-starts instead of 3 WEBSITE_CATALOGUE_UPDATES.md: - Add Codex and Gemini sections to "By Provider" learning page structure - Update implementation prompt to include all 5 providers - Update catalogue structure for 5 provider-specific guides PHASE_2_EXECUTION_PLAYBOOK.md: - Update provider intent section to include Claude, Codex, Copilot, Gemini, and OpenAI PROMPT_BATCH_2_TOUR_OPERATOR_CONFIG_AGENT.md: - Add plugin package directory checklist requirement to success criteria PROMPT_BATCH_2_WP_CONFIG_AGENT.md: - Add plugin package directory checklist requirement to success criteria PROMPT_BATCH_2_AGENTS_5_14.md: - Add all 10 agent plugin packages checklist requirement to success criteria Four-provider contract now established across all documentation. All future agents will target Claude, Copilot, Codex, Gemini, and OpenAI with consistent plugin structure, quick-start guides, and validation requirements. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com> * fix: bump docs/ISSUE_FIELDS.md version to v1.0.8 for frontmatter freshness * fix: add missing 50 limit references to docs/ISSUE_FIELDS.md section 3.1 --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Summary
Merge four-provider contract updates (Claude, Copilot, Codex, Gemini, OpenAI) to complete Phase 2 documentation framework.
Changes
Documentation Files Updated:
Agent Batch Prompts Updated:
Validation
All documentation files lint clean. Four-provider contract now established across:
Ready to merge to develop as PR #1144.