ci: fix linting workflow blockers — consolidate duplicate checks, exclude temporary directories#1159
Conversation
Add comprehensive planning documentation for bulk project creation system with template-driven field initialization. Includes: - INDEX.md: Project overview and navigation - PLANNING.md: Full architectural blueprint with field mappings, CSV schema, agent and workflow design, implementation roadmap - SUMMARY.md: Quick overview and GitHub issue creation guide - ISSUES.md: Copy-paste ready Epic and Story issue templates Two template types planned: 1. Client Delivery (Scrumban + UAT): Status Backlog→Todo→Done, 9 views 2. Product Development (Release Train): Status Backlog→Ready→Done, 8 views Shared fields across both templates (14 core): Priority, Type, Effort, Area, Theme, Size, Dates, Milestone, Environment, Parent Issue, Sub-issues Progress, Time Implementation: 4 phases, 3–4 weeks, 4–5 developers - Phase 1: Foundations (CSV schema, agent scaffold, workflow) - Phase 2: Client Delivery template (1–2 weeks, parallel) - Phase 3: Product Development template (1–2 weeks, parallel) - Phase 4: PR Type syncing + docs (1 week) Depends on: #1145 (org issue-field writer), #1146 (secret-gating) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…dardize Node versions Addresses critical CI issues blocking PR #1144 and future development: **Changes:** - Delete duplicate .github/workflows/linting.yml (consolidate into checks.yml) - Exclude .claude/** from markdown linting (temporary worktree directories) - Exclude agents/** from markdown linting (code examples, not prose docs) - Standardize Node version to .nvmrc across all workflow jobs **Impact:** - Resolves 2348+ markdown linting errors from temporary directories - Eliminates redundant duplicate linting workflow runs - Fixes Mergify cascading failures - Allows PR #1144 and future PRs to pass CI checks Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added
priority:critical
|
✅ Template check passed after update. Thanks for fixing the PR description. |
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow. |
🔍 Reviewer Summary for PR #1159CI Status: ❌ Recommendations
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe2904e0fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "lint:all": "npm run lint && npm run lint:workflows && npm run lint:md && npm run lint:json", | ||
| "lint:js": "eslint '**/*.{js,jsx,ts,tsx}' --ignore-pattern 'design_handoff_awesome_github/**' --ignore-pattern 'website/**' --fix", | ||
| "lint:md": "markdownlint-cli2 \"**/*.{md,mdx}\" \"!node_modules\" \"!website/**\" \"!wceu-2026/**\" \"!.github/projects/**\" \"!.github/reports/**\" \"!AWESOME_GITHUB_MAPPING_STRATEGY.md\" \"!docs/MIGRATION.md\" \"!**/plugin-provided/**\" \"!**/platform-managed/**\" \"!**/directory-installed/**\" \"!**/tests/markdown-issues.md\" \"!**/agentskills-main/**\"", | ||
| "lint:md": "markdownlint-cli2 \"**/*.{md,mdx}\" \"!node_modules\" \"!website/**\" \"!wceu-2026/**\" \"!.github/projects/**\" \"!.github/reports/**\" \"!.claude/**\" \"!agents/**\" \"!AWESOME_GITHUB_MAPPING_STRATEGY.md\" \"!docs/MIGRATION.md\" \"!**/plugin-provided/**\" \"!**/platform-managed/**\" \"!**/directory-installed/**\" \"!**/tests/markdown-issues.md\" \"!**/agentskills-main/**\"", |
There was a problem hiding this comment.
When an agents/**/*.md specification changes, this negated glob prevents both npm run lint:md and the unified workflow's lint job from checking it; the target tree contains thousands of tracked Markdown specifications rather than only generated code examples. Narrow the exclusion to the genuinely problematic generated paths or use targeted rule overrides so structural regressions in canonical agent specifications cannot merge unnoticed.
AGENTS.md reference: AGENTS.md:L34-L35
Useful? React with 👍 / 👎.
| - Area: Frontend, Backend, Content, A11y, Analytics, Build & CI, DevOps | ||
| - Theme: Checkout, Performance, Editor UX, Migration, Configuration, SEO | ||
| - Size, Start Date, Deadline, Milestone, Environment, Parent Issue, Sub-issues Progress, Time (hours) |
There was a problem hiding this comment.
When Story A is implemented from this copy-ready specification, Area, Theme, Size, Deadline, Milestone, Environment, Parent Issue, Sub-issues Progress, and Time cannot be sourced from .github/issue-fields.yml as claimed because that configuration does not define them. Either add these fields and their values to the canonical configuration or identify them as template-specific with an explicit source; otherwise the field-parity acceptance criterion is impossible without inventing a second vocabulary.
Useful? React with 👍 / 👎.
|
|
||
| **Milestone**: v1.0 | ||
| **Assignee**: [TBD] | ||
| **Labels**: `type:epic`, `area:automation`, `area:projects`, `domain:dotgithub-governance`, `priority:important`, `status:ready` |
There was a problem hiding this comment.
When the epic or stories are created using these instructions, area:projects and domain:dotgithub-governance cannot be selected because neither label exists in the target revision's .github/labels.yml. Replace them with existing canonical labels or add their definitions; otherwise the advertised copy-ready issue setup cannot be completed as written.
Useful? React with 👍 / 👎.
| | [WORK-BREAKDOWN.md](./WORK-BREAKDOWN.md) | Task breakdown, effort, timeline (12 KB) | Project managers, developers | | ||
| | [TEMPLATE-COMPARISON.md](./TEMPLATE-COMPARISON.md) | Visual template comparison (12 KB) | All stakeholders | |
There was a problem hiding this comment.
These quick links are broken because a repo-wide search of the target tree finds neither WORK-BREAKDOWN.md nor TEMPLATE-COMPARISON.md; the same absent files are also presented as required reading in SUMMARY.md. Add the documents in this directory or remove the links so stakeholders are not routed to missing implementation guidance.
Useful? React with 👍 / 👎.
| - [x] Template specification provided: `github-projects-client-delivery.md` | ||
| - [x] Field mapping documented: 14 fields with canonical values from issue-fields.yml | ||
| - [x] Automations defined: 5 core rules | ||
| - [x] Views documented: 9 views including UAT (Client) | ||
| - [x] Parent Epic #[TBD] created and linked |
There was a problem hiding this comment.
When this section is copied as directed, the Definition of Ready claims that github-projects-client-delivery.md is provided and that the parent epic is created and linked, but the target tree contains no such specification and the parent remains #[TBD]. Keep these boxes unchecked until the artefacts and issue number exist, and require placeholder substitution before posting, rather than producing a falsely ready story.
AGENTS.md reference: AGENTS.md:L126-L130
Useful? React with 👍 / 👎.
| @@ -1,19 +0,0 @@ | |||
| name: lint | |||
There was a problem hiding this comment.
Deleting this workflow leaves published repository guidance pointing to a file that no longer exists: the repo-wide search still finds linting.yml in the workflow inventory and trigger summary, release documentation, and numerous status badges such as those in docs/BRANCHING_STRATEGY.md and tests/README.md. Update those references to checks.yml as part of the consolidation so the workflow inventory and badges remain usable.
Useful? React with 👍 / 👎.
|
Linked Issue: #1162 ci: fix linting workflow blockers and Mergify cascading failures Closes #1162 |
|
@Mergifyio queue |
Metadata governance
|
…w references Address Codex review feedback: **Changes:** 1. Revert `agents/**` exclusion from markdown linting (canonical specs should be linted) 2. Keep only `.claude/**` exclusion (temporary directories) 3. Add required PR template sections (Linked issues, Changelog, Global DoD) 4. Update all references to `linting.yml` → `checks.yml` across: - agents/release.agent.md (3 references) - docs/RELEASE_PROCESS.md (1 reference) - docs/WORKFLOW_COORDINATION.md (4 references) **Rationale:** - Agent specifications are tracked canonical docs that should be linted - Pre-existing agent markdown issues should be addressed in separate PR - Consolidating linting.yml → checks.yml requires updating all references Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Addressing Codex Review Feedback✅ All feedback addressed: 1. Restore linting for canonical agent specifications
2. Update references before deleting linting.yml
3. PR Template completeness
Summary of fixes in this push:
Ready for review. |
Frontmatter governance requires version and last_updated to be updated whenever file content changes. **Files updated:** - agents/release.agent.md: v2.4 → v2.5, last_updated: 2026-07-23 - docs/RELEASE_PROCESS.md: v2.2.1 → v2.2.2, last_updated: 2026-07-23 - docs/WORKFLOW_COORDINATION.md: v1.1.4 → v1.1.5, last_updated: 2026-07-23 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
… update PR template **Changes:** - Add missing '50' field limit references to docs/ISSUE_FIELDS.md section 3.1 - Update PR #1159 body to match proper CI template format with required sections: - Build/CI change (What/Why) - Baseline & Target - Rollback plan - Notes - Changelog with subsections (Added/Changed/Fixed/Removed) - Bump docs/ISSUE_FIELDS.md version from v1.0.7 to v1.0.8 **Fixes:** - Resolves issue-fields validation error - Resolves validate-pr-template error Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
github-actions
Bot
added
status:needs-review
github-actions
Bot
added
the
meta:needs-changelog
…ion system (MVP for #1145) Added org-level issue field writer scaffolding with field ID mapping configuration template. Updated docs/ISSUE_FIELDS.md with complete org-level field specification, marking updateOrgIssueFields as pending implementation. Added comprehensive planning system documentation for GitHub Projects bulk creation with template-driven field initialisation (4 planning docs: INDEX.md, PLANNING.md, SUMMARY.md, ISSUES.md with epic and story templates). Applied all CodeRabbit feedback: UK spelling standardisation (initialisation), view count corrections (9 views for both templates), parent-epic checkbox fixes, missing Status field addition to shared fields table, and complete field-ID example documentation. Changes: - docs/ISSUE_FIELDS.md: Added org-level field writer section (not yet implemented), field ID mapping example with all 6 fields - .github/projects/active/github-projects-creation-system/INDEX.md: UK spelling fixes, dependency status clarification - .github/projects/active/github-projects-creation-system/PLANNING.md: UK spelling standardisation - .github/projects/active/github-projects-creation-system/SUMMARY.md: View count updates, shared fields table with Status field - .github/projects/active/github-projects-creation-system/ISSUES.md: DoR checkbox corrections, view specifications - CHANGELOG.md: Feature entry for org issue-field writer infrastructure - .remember/now.md: Session notes Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
1 participant
Linked issues
Closes #1162
Build/CI change
What: Consolidate duplicate linting workflows and exclude temporary directories from linting.
.github/workflows/linting.yml.claude/**(temporary worktree directories) from markdown linting.nvmrcacross all workflow jobsWhy: These changes fix critical CI blockers preventing all PRs from merging. 2,348+ linting errors from temporary directories cascaded through CI, blocking PR #1144 and subsequent work.
Baseline & Target
Rollback
.github/workflows/linting.ymlif issues ariseNotes
linting.ymltochecks.ymlChangelog
Added
Changed
linting.ymlandchecks.ymlworkflows into unifiedchecks.yml.nvmrcacross lint, test, and validate jobsFixed
.claude/**directories from markdown linting (resolves 2,348+ cascading errors)Removed
.github/workflows/linting.ymlworkflowChecklist (Global DoD / PR)