Disambiguate NCronJob instant runs - #546
Merged
Merged
Conversation
Co-authored-by: linkdotnet <26365461+linkdotnet@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, consistent with the repository’s NCronJob usage requirements, and does not introduce behavioral risk beyond resolving the overload ambiguity.
Pull request overview
This PR updates the admin Settings page to disambiguate NCronJob instant job triggers by explicitly passing a null job parameter, aligning the call site with the required overload for the current NCronJob version.
Changes:
- Updated
RunInstantJob<TJob>()invocations toRunInstantJob<TJob>(parameter: null)for jobs that do not require a parameter. - Applies this fix to both the visit transformer and broken link checker instant-run buttons.
File summaries
| File | Description |
|---|---|
| src/LinkDotNet.Blog.Web/Features/Admin/Settings/SettingsPage.razor | Explicitly passes parameter: null to RunInstantJob to avoid overload ambiguity when triggering instant jobs from the settings UI. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.