Refresh docs guidance and pin DocFX builds - #316
Merged
Merged
Conversation
Co-authored-by: linkdotnet <26365461+linkdotnet@users.noreply.github.com>
Co-authored-by: linkdotnet <26365461+linkdotnet@users.noreply.github.com>
Co-authored-by: linkdotnet <26365461+linkdotnet@users.noreply.github.com>
Co-authored-by: linkdotnet <26365461+linkdotnet@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
linkdotnet
September 20, 2026 10:17
View session
linkdotnet
marked this pull request as ready for review
September 20, 2026 10:17
linkdotnet
deleted the
copilot/update-documentation-and-code-samples
branch
September 20, 2026 10:18
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate issues remain in the DocFX helper and documentation sample tests, with additional examples needing correction.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (5)
What changed in this PR
This pull request refreshes builder-selection documentation, adds executable samples and agent-friendly docs, and pins DocFX 2.80.1 for local and CI builds.
Changes:
- Clarifies builder selection and fixed-size fallback behavior.
- Adds
llms.txt, navigation updates, and machine-friendly DocFX resources. - Adds documentation sample tests and standardizes DocFX tooling.
| File | Summary and final review notes |
|---|---|
tests/LinkDotNet.StringBuilder.UnitTests/DocumentationSamplesTests.cs |
Adds sample tests. Moderate: culture-dependent float assertion and untested fit path. |
README.md |
Updates builder guidance. Nit: constants never demonstrate the allocation-free path. |
docs/site/llms.txt |
Adds agent-oriented links and guidance. Nit: overflow guidance is broader than the examples. |
docs/site/index.md |
Refreshes documentation landing guidance. |
docs/site/docfx.json |
Configures schema, text resources, and search indexing. |
docs/site/articles/toc.yml |
Adds the builder-selection guide to navigation. |
docs/site/articles/getting_started.md |
Clarifies recommended entry points. |
docs/site/articles/choosing_builder.md |
Adds builder-selection guidance. Nits: dead overflow paths and overstated allocation-free behavior. |
docs/serve_docs.cmd |
Pins local DocFX usage. Moderate: downgrade handling may fail for newer installed versions. |
.github/workflows/docs.yml |
Pins DocFX in CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| builder.Append("id="); | ||
| builder.Append(userId); | ||
|
|
||
| if (builder.Remaining < suffix.Length + userName.Length) |
| builder.Append("id="); | ||
| builder.Append(userId); | ||
|
|
||
| if (builder.Remaining < suffix.Length + userName.Length) |
| builder.Append("id="); | ||
| builder.Append(userId); | ||
|
|
||
| if (builder.Remaining < suffix.Length + userName.Length) |
| return builder.ToString(); | ||
| ``` | ||
|
|
||
| This keeps the common path allocation-free while still giving you a safe way to continue building when the fixed buffer is no longer enough. |
|
|
||
| - Default to `ValueStringBuilder` for examples, recommendations, and generated code. | ||
| - Treat `FixedSizeValueStringBuilder` as a specialized builder for hard "must never grow" limits. | ||
| - Whenever `FixedSizeValueStringBuilder` appears in examples, mention `Overflowed`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This updates the docs to better reflect the library’s two builder types:
ValueStringBuilderas the default path, andFixedSizeValueStringBuilderas the specialized no-growth option. It also tightens the DocFX setup so published docs and local/CI builds use a consistent toolchain.Clarify builder selection
ValueStringBuilder, stack-backedValueStringBuilder,FixedSizeValueStringBuilder, andSystem.Text.StringBuilder.Improve agent-friendly documentation
llms.txtentry point with direct links to the canonical markdown sources and key rendered pages.Keep docs examples executable
Stabilize DocFX usage
2.80.1in the docs workflow and local helper script.docfx.jsonand made the search-index post-processor explicit.