Skip to content

fix(ui): enable QPainter antialiasing for Qt6 build - #521

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-qt6-antialiasing
Aug 25, 2026
Merged

fix(ui): enable QPainter antialiasing for Qt6 build#521
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-qt6-antialiasing

Conversation

@add-uos

@add-uos add-uos commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Add QPainter::Antialiasing render hint for switchcamerabtn and takephotosettingareawidget, which were missing it under Qt6.

Qt6下switchcamerabtn和takephotosettingareawidget的paintEvent 未设置抗锯齿,导致圆形边框绘制出现锯齿。

Log: Qt6下开启抗锯齿修复边框锯齿
Influence: 修复Qt6下切换摄像头按钮和拍照设置区域边框锯齿问题,提升显示效果。

Summary by Sourcery

Enable antialiasing for the affected widgets to improve border rendering in Qt6 builds.

Bug Fixes:

  • Fix jagged circular borders in the camera-switch button and photo-settings area when built with Qt6 by enabling painter antialiasing.

Chores:

  • Update copyright year ranges in the affected source files.

Add QPainter::Antialiasing render hint for switchcamerabtn and
takephotosettingareawidget, which were missing it under Qt6.

Qt6下switchcamerabtn和takephotosettingareawidget的paintEvent
未设置抗锯齿,导致圆形边框绘制出现锯齿。

Log: Qt6下开启抗锯齿修复边框锯齿
Influence: 修复Qt6下切换摄像头按钮和拍照设置区域边框锯齿问题,提升显示效果。
@sourcery-ai

sourcery-ai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR fixes jagged circular borders in Qt6 by enabling QPainter antialiasing for the switch-camera button and photo-setting-area widget while preserving the existing Qt5 rendering hint behavior.

Sequence diagram for Qt6 widget painting with antialiasing

sequenceDiagram
    participant Qt as QtPaintSystem
    participant SwitchCameraBtn
    participant PhotoSettingAreaWidget
    participant QPainter

    Qt->>SwitchCameraBtn: paintEvent(QPaintEvent)
    SwitchCameraBtn->>QPainter: setRenderHint(QPainter::Antialiasing, true)
    QPainter-->>SwitchCameraBtn: Paint circular border smoothly

    Qt->>PhotoSettingAreaWidget: paintEvent(QPaintEvent)
    PhotoSettingAreaWidget->>QPainter: setRenderHint(QPainter::Antialiasing, true)
    QPainter-->>PhotoSettingAreaWidget: Paint circular border smoothly

    alt Qt5 build
        SwitchCameraBtn->>QPainter: setRenderHint(QPainter::HighQualityAntialiasing, true)
        PhotoSettingAreaWidget->>QPainter: setRenderHint(QPainter::HighQualityAntialiasing, true)
    end
Loading

File-Level Changes

Change Details Files
Enable QPainter antialiasing in the two affected widget paint paths so circular borders render smoothly in Qt6.
  • Set the QPainter::Antialiasing render hint in each paintEvent.
  • Retain the Qt5-specific HighQualityAntialiasing hint for backward compatibility.
src/src/switchcamerabtn.cpp
src/src/takephotosettingareawidget.cpp
Update copyright year ranges in the modified source files.
  • Extend copyright notices through 2026.
src/src/switchcamerabtn.cpp
src/src/takephotosettingareawidget.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@add-uos

add-uos commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot
deepin-bot Bot merged commit a7dc9ac into linuxdeepin:master Aug 25, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants