Add Grimmory subdomain config - #813
Open
NaruZosa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a sample subdomain config for Grimmory.
Benefits of this PR and context
Grimmory is a maintained fork of Booklore, which had a sample config requested in #770
Please note that the Kobo integration docs specify Nginx requires the following settings:
The sample config includes these, and is functional. When testing without these settings, syncing on my Kobo failed and SWAG logged the following error:
[error] 617761#617761: *7653 upstream sent too big header while reading response header from upstream, client: <REDACTED_IP>, server: grimmory.*, request: "GET /api/kobo/<REDACTED_API_TOKEN>/v1/library/sync?Filter=ALL&DownloadUrlFilter=Generic,Android&PrioritizeRecentReads=true HTTP/1.1", upstream: "http://<CONTAINER_IP>:6060/api/kobo/<REDACTED_API_TOKEN>/v1/library/sync?Filter=ALL&DownloadUrlFilter=Generic,Android&PrioritizeRecentReads=true", host: "grimmory.<REDACTED_DOMAIN>.com"These settings conflict with
/config/nginx/proxy.confso thelocation /api/kobo/does not include the lineinclude /config/nginx/proxy.conf;.How Has This Been Tested?
Tested and in active use on my instance, including the Kobo sync integration.
Source / References