Refactor code in method checker#247
Merged
Merged
Conversation
rcosta358
approved these changes
Jun 9, 2026
| String constructorName = "<init>"; | ||
| String k = Utils.getSimpleName(prefix); | ||
| boolean isConstructor = Utils.getSimpleName(prefix).equals(method.getSimpleName()); | ||
| String functionName = isConstructor ? constructorName : String.format("%s.%s", prefix, method.getSimpleName()); |
Collaborator
There was a problem hiding this comment.
We can replace the repeated String.format("%s.%s", prefix, name) with Utils.qualifyName(prefix, name).
Comment on lines
+114
to
+115
| * Creates a {@link RefinedFunction} with the shared boilerplate (sanitized name, type, empty return refinement, | ||
| * placement, optional owning class and signature), registers it in the context, and processes its parameter/return |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Creates a {@link RefinedFunction} with the shared boilerplate (sanitized name, type, empty return refinement, | |
| * placement, optional owning class and signature), registers it in the context, and processes its parameter/return | |
| * Creates a {@link RefinedFunction} with the sanitized name, type, empty return refinement, | |
| * placement, optional owning class and signature, and registers it in the context, and processes its parameter/return |
CatarinaGamboa
force-pushed
the
refactor-method-checker
branch
from
cab0b30 to
df05abb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the code in method checker by:
if ( a != null ) { huge code chunk }->if( a == null ) { return }Type of change
Checklist
liquidjava-example/src/main/java/testSuite/(Correct*/Error*)mvn testpasses locally