fix(rime): remove Arcana model support - #2253
Conversation
🦋 Changeset detectedLatest commit: e73b5b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
c40bc26 to
1e6af9c
Compare
naszzz
changed the title
| if (opts.modelId === 'coda') { | ||
| if (opts.repetition_penalty !== undefined) params.repetition_penalty = opts.repetition_penalty; | ||
| if (opts.temperature !== undefined) params.temperature = opts.temperature; | ||
| if (opts.top_p !== undefined) params.top_p = opts.top_p; | ||
| if (opts.max_tokens !== undefined) params.max_tokens = opts.max_tokens; | ||
| if (opts.timeScaleFactor !== undefined) params.timeScaleFactor = opts.timeScaleFactor; |
There was a problem hiding this comment.
🟡 Voice tuning settings are silently ignored when the older Rime voice model is still selected
Tuning values such as speed, randomness and length limits are dropped from the request (modelParams at plugins/rime/src/tts.ts:92-109) whenever the older arcana model name is passed, so speech is generated with default settings instead of the configured ones and no error is raised.
Impact: Users who still specify the old Rime model get audio that ignores their configured voice tuning, with no warning.
Parameter branch no longer matches the legacy model id
modelId is typed TTSModels | string (plugins/rime/src/tts.ts:56), so 'arcana' is still accepted at runtime even though it was removed from the TTSModels union (plugins/rime/src/models.ts:6). Previously modelParams had an opts.modelId === 'arcana' branch that forwarded repetition_penalty, temperature, top_p, max_tokens and timeScaleFactor. After this change only 'coda' and *mist* are matched, so an arcana request falls through and emits only lang. Those keys are also explicitly excluded from the passthrough loop in fetchPayload (plugins/rime/src/tts.ts:139-144), so they cannot reach the payload by any other route. The result is a silently under-configured request rather than an explicit error, which contradicts the stated intent of keeping the legacy runtime path working during the compatibility window. Either restore the legacy branch or reject the legacy model id with a clear error.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Intentional under the revised scope. This PR now removes Arcana runtime support and directs users to Coda.
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@livekit/agents': minor | |||
There was a problem hiding this comment.
could these be switched to patch?
| if (opts.lang !== undefined) params.lang = opts.lang; | ||
|
|
||
| if (opts.modelId === 'arcana') { | ||
| if (opts.modelId === 'coda') { |
There was a problem hiding this comment.
same comment as the python pr, we can throw a warning when a user uses the arcana model
3 participants
Summary
Migration notice: https://docs.rime.ai/docs/arcana-sunset