Add separately configurable liveness and readiness probes - #166
Open
feldgendler wants to merge 1 commit into
Open
Add separately configurable liveness and readiness probes#166feldgendler wants to merge 1 commit into
feldgendler wants to merge 1 commit into
Conversation
This was referenced Aug 21, 2026
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116, and supersedes #161 — same configurability, plus a change to the liveness default.
The chart hardcodes the same
GET /check for bothlivenessProbeandreadinessProbe, so the two can't be tuned apart without forking the chart. Both are values now; setting either to~omits that probe.Liveness also moves from
GET /to a TCP check on the same port.GET /returns 406 once the node's stats are more than 4s stale, and on a redis deployment those stats are refreshed by a keepalive that round-trips through redis, so a redis outage longer than about 35s fails liveness on every node at the same moment and restarts the whole fleet — which does nothing to bring redis back (livekit/livekit#4663). Readiness keepsGET /, which is where staleness belongs: the node stops taking new sessions and starts again on its own once redis recovers. Every other probe field keeps the value Kubernetes was already defaulting it to, exceptlivenessProbe.initialDelaySeconds, which goes from 0 to 10 to cover a cold start.Also adds the chart's first unit tests (helm-unittest) and a CI step to run them before
ct lint, since the liveness default is easy to regress by accident.tests/is in.helmignoreso it isn't packaged.One question: I left
Chart.yamlalone, since version bumps here happen in release commits — but nothing reaches operators until the version moves, so say the word if you'd rather this carried 1.11.1.