chore: drop dead on_complete, escape glob metachars, strict semver tags - #12
Merged
Merged
Conversation
- plugin_manager#async#on_complete: zero call sites; the 2.2.4 sweep already claimed its removal, it survived - deleted now (issue #11) - remove: escape glob metachars in the fuzzy filesystem search so a metachar name can never match an unrelated plugin - release: validate tags with ^v[0-9]+\.[0-9]+\.[0-9]+$ in release.yml (new step before archive) and the Makefile tag target (was: ^v only) Closes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three quality items from the audit (issue #11): remove the dead
plugin_manager#async#on_complete(the 2.2.4 sweep claimed it, it survived), escape glob metachars in the remove filesystem search, and enforce strict semver^v[0-9]+\.[0-9]+\.[0-9]+$on release tags (release.yml step + Makefile tag target).Type of change
Related issue
Fixes #11
How was this tested?
make test-cipasses (209/209, +3 quality tests, written test-first)make test-asyncpasses (16/16)Note: the semver Vader test pins the exact pattern shared by release.yml and the Makefile so the two cannot drift.
Checklist
type(scope): subject)g:plugin_manager_*flag defaulting to off)v:version < 802untouched)