fix(core): eliminate silent failures, WARN on every degraded outcome - #8
Merged
Merged
Conversation
Every swallowed failure now leaves a WARN trace (debug_mode-independent, issue #5 contract) and the sidebar reports the truth: - git#add_submodule: check the pointer commit, fail the add on error - remove: check deinit + commit_removal; op label reflects commit failure; fix double vim_dir prefix on absolute module paths - update: warn on unreachable pin target; stash push failure no longer pretends a stash exists (phantom pop); auto-commit failure downgrades the op and footer - vimrc/helptags/check/async/add/declare/backup/util: warn on the previously invisible failure branches tests/log_warnings.vader: 15 WARN regression tests with debug_mode unset. Closes #7
Permission bits do not block root (CI containers run as root): a tags DIRECTORY plus a valid help file makes :helptags fail with E152 for every user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every degraded outcome (failed git command, failed callback, failed stash/copy/mkdir) now writes a WARN line to the log with
debug_modeoff, and sidebar labels/footer report the truth instead of an optimistic status. Completes the issue #5 contract across the 15 remaining silent sites.Type of change
Related issue
Fixes #7
How was this tested?
make test-cipasses (199/199, +15 WARN regression tests withdebug_modeunset)make test-asyncpasses (16/16)Notable fixes beyond the WARN lines:
git#add_submodulenow fails when the pointer commit fails (was: result discarded)update#stash_if_neededreturns 0 whengit stash pushfails (was: 1, causing a phantomstash pop)removeno longer double-prefixesvim_diron absolute module paths (filesystem-search removals)helptagsfailure is labeled "Helptags failed", not "skip / No doc directory"Checklist
type(scope): subject)g:plugin_manager_*flag defaulting to off)v:version < 802untouched)