e2e: dump device logcat on Android flow failure - #19
Merged
Merged
Conversation
OCaml lui_* FFI exceptions and [NativeEffect] drain traces land in logcat but were never captured when a Maestro flow failed — clear the buffer per flow and dump the tail on failure. Also gate the local db-sync port wait behind LOGSEQ_CHAT_ANDROID_E2E_SKIP_DB_SYNC_WAIT so the runner self-test (which never starts a server) doesn't stall 6 minutes, and update the runner test's expected module list for the 'smoke' module.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the exception-logging fix: the diagnostics it prints land in device logcat, but
test-android-e2e.shnever captured logcat when a Maestro flow failed — the evidence still vanished. Now each flow clears the buffer before running and dumps the last 400 lines on failure, so thelogseq_chat:exception line andempty patch from <source>drain traces surface directly in CI output.Two runner-test repairs that were already broken on main:
connectinvocation points athttp://127.0.0.1:8787and stalled ~6min before dying. Gated behindLOGSEQ_CHAT_ANDROID_E2E_SKIP_DB_SYNC_WAIT, set in the self-test.smoke(added later) — updated.Link to Devin session: https://app.devin.ai/sessions/9a91e201984a4d4f96ce3e0f86ac6668
Open in Devin Desktop: https://app.devin.ai/desktop/session/9a91e201984a4d4f96ce3e0f86ac6668?variant=devin
Requested by: @tiensonqin