flutter: bump lui pin for modal/grow/scroll fixes + drain trace filter - #21
Merged
Merged
Conversation
The _traceNativeEffect keyword whitelist silently dropped every 'applying patch from <source>' / 'empty patch from <source>' trace that didn't name a whitelisted effect kind — which is what made the graph- create wedge look like a Dart-side silence. Let any trace containing 'patch' through so apply outcomes stay visible.
The Android e2e wedge was partly invisible because nothing asserted the sheet actually unmounts — it lingered in the a11y tree for 60s.
Picks up lui#40 (grow on stack children + box), lui#43 (modal-route ghost: deferred pop + forced semantics re-emit + stale-id guards), lui#44 (scroll defaults vertical — invisible-sheet fix), lui#45 (ListItem double-tap + M3 test regressions). Together they resolve the Android e2e button.sidebar wedge.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Android e2e wedge where
button.sidebartimed out 60s after graph creation — three stacked changes:lui_flutter_backendpindb506b5→2a2cc62: picks up the four merged lui fixes that resolve the wedge end-to-end — lui#40 (stack/boxhonorgrow; the journals pane'sRenderViewportwas getting0<=h<=Infinityand never laid out), lui#43 (modal-route ghost: with an a11y client attached the dismissed sheet's overlay entries stranded the a11y tree onlayout.graph-create.sheet), lui#44 (scrolldefaulted to horizontal → invisible sheets), lui#45 (ListItem double-tap + M3 test regressions)._traceNativeEffect'skind=-keyword whitelist silently dropped everyapplying patch from <source>/empty patch from <source>trace (nokind=token), which made a healthy drain look dead in logcat during the investigation. Patch traces now pass through.cold-start-create-graph.drivenow assertsexpect-absent prop:accessibility-identifier=sheet.graph-create— nothing previously verified the sheet actually leaves the patch tree after graph creation.The Android e2e job should exercise the new lui backend end-to-end on this PR.
Link to Devin session: https://app.devin.ai/sessions/9a91e201984a4d4f96ce3e0f86ac6668
Open in Devin Desktop: https://app.devin.ai/desktop/session/9a91e201984a4d4f96ce3e0f86ac6668?variant=devin
Requested by: @tiensonqin