fix datascript pin: point at merged commit e439cba8 - #28
Merged
Merged
Conversation
The previous pin e439cbac was a pre-merge PR head that isn't fetchable from the datascript remote; point at the equivalent squash-merged main commit e439cba8.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ocaml-core on main is red: opam fails to sync
datascript-ocamlbecause the pine439cbac48b28800820984ea3e285cf26a4f92b5is the pre-merge head of logseq/datascript-ocaml#19 — the PR was squash-merged, so that SHA is not fetchable from the remote (Commit not found on repository→Package conflict!, exit 20).Repoints both pins at the equivalent merged main commit
e439cba85fa0a5b35277959f4737510e3b6a45a7(same tree). Verified locally: vendored duniverse updated to that commit anddune build @shared/native/runtestpasses all 718 tests.Link to Devin session: https://app.devin.ai/sessions/eab2eca00a5649d09fcf48626d9f09ef
Open in Devin Desktop: https://app.devin.ai/desktop/session/eab2eca00a5649d09fcf48626d9f09ef?variant=devin
Requested by: @tiensonqin