[sw,dv] Add SW-DV logging - #600
Merged
Merged
Conversation
martin-velay
force-pushed
the
sw_dv_log
branch
2 times, most recently
from
June 5, 2026 06:27
7241605 to
b88ffc4
Compare
martin-velay
marked this pull request as ready for review
June 5, 2026 16:05
rswarbrick
reviewed
Jul 15, 2026
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
A couple of nitty comments but this looks nice.
(And the review took me a while: I hadn't seen the clever variadic macro trick before!)
Contributor
Author
|
I've just rebased and fix the merge conflicts. There was also an issue for CHERI tests. Now Verilator tests pass and the UVM tests too (new tests And the log gives: |
rswarbrick
approved these changes
Jul 15, 2026
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
This looks really good to me.
Thanks for the updates (and for teaching me about variadic macros in C...)
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Some comments from my end.
engdoreis
reviewed
Jul 15, 2026
The upstream script assumes a 32-bit struct layout (5 x uint32, 20 B, LONG header). Mocha's rv64 log_fields_t uses 8-byte const char * pointer fields, giving a 32-byte struct and an 8-byte QUAD section-address header. Under CHERI those pointers are 16-byte capabilities, forcing 16-byte section alignment, a 16-byte header and 64-byte entries, with the file/format addresses held in __cap_relocs rather than the section. Add a patch that selects the layout from the ELF class and the .logs.fields alignment, and resolves capability pointer fields from __cap_relocs when present. Wire the script into build_sw_collateral_for_sim.py so each CMake install step produces the .logs.txt and .rodata.txt files that sw_logger_if needs at simulation start. Signed-off-by: martin-velay <mvelay@lowrisc.org>
Each call site places a log_fields_t entry in a new .logs.fields ELF section; extract_sw_logs.py produces the database consumed by sw_logger_if to decode printf-style messages at simulation start, with no UART overhead. Add a log field at offset 0x8 of the dv_window_memory_layout struct and route dv_log_write() through mocha_system_dv_window() for CHERI-safe access to the log write port (0x2002_0008). Add the .logs.fields section to the linker script after .rodata so string constants are resolved before log entries are laid out. Add dv_log.h/c implementing the DV_LOG_INFO/WARNING/ERROR/FATAL macros and the runtime dv_log_write() function. Add dv_log_smoketest to verify the end-to-end path. Signed-off-by: martin-velay <mvelay@lowrisc.org>
Signed-off-by: martin-velay <mvelay@lowrisc.org>
Signed-off-by: martin-velay <mvelay@lowrisc.org>
engdoreis
approved these changes
Jul 16, 2026
engdoreis
left a comment
engdoreis
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but let's wait for Marno's approval before merging.
marnovandermaas
approved these changes
Jul 24, 2026
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Happy for you to merge when you think it is ready.
This was referenced Jul 24, 2026
Contributor
Author
|
Mentioned issues have been created and I ran again a UVM little regression and all looks good. Thank you all for you reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue: #261