Conversation
…forwarded role (lidge-jun#5334 follow-up) lidge-jun#5334 made the developer wire role tri-state: an undeclared destination folds it to system. Two suites asserting role:"developer" on the Chat wire were missed because they are about tool-result repair ordering and document parts, not role selection — declare the destination, per the convention the change established. Verified: both files fail on dev@600075d2 with system-for-developer wire roles and pass with the declaration. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Consolidated into lidge-jun#5541 as a single related-function aggregate. Source head: All unique Devin contribution commits are carried with original authors and provenance. Six match complete stable patch IDs; the alias-host change matches the code/test/runtime-document patch IDs and its one table-row conflict preserves both contracts. The common f700c56 role-fixture change is already present in both corresponding provider objects on the base, so it was not duplicated. Integration regressions verify exact 429 timing, no raw credential reflection, one physical send, and the alias-bound EU tenant path. Devin tests: 252 passed; layout:18 passed; ratchet:9 passed; typecheck/structure/privacy passed. Full cross-platform CI and independent review remain pending. Closing this duplicate standalone review entry at the author's request after verifying migration. This is not a merge or release claim; remaining integration checks and reviews are tracked on the draft replacement. Original branches are retained. |
Motivation
devin/devin-clirekey window and separately-sourced keys coexist.Description
apiKeyparameter toresolveDevinApiServerand require the alias credential toaccess === apiKeybefore borrowing itsapiBaseUrlinsrc/oauth/devin.ts.resolveDevinApiServerfromsrc/adapters/devin.tsso host and key are resolved as a bound snapshot.tests/providers/devin-adapter.test.tsthat proves an independently configured key cannot borrow an alias slot's tenant host, and updatetests/providers/devin-login.test.tsto exercise the new binding.structure/runtime.mdandstructure/providers-and-adapters.mdto declare that alias-host fallback is only allowed when the alias credential owns the transmitted key.Testing
bun test tests/providers/devin-adapter.test.ts tests/providers/devin-login.test.tsand both focused test files passed (66 tests total).bun run typecheck,bun run structure:check, andbun run privacy:scan, all of which succeeded.bun test tests/ci-workflows/file-size-ratchet.test.tswhich passed its checks.bun run testexecution in this container produced unrelated environment/timing and process-group failures (focused Devin coverage passed; full run: 27,761 passed, 34 skipped, 181 failed, 2 errors) so only the focused Devin tests are relied on for regression verification.Codex Task