Skip to content

fix(devin): bind alias tenant host to credential key - #579

Closed
luvs01 wants to merge 2 commits into
devfrom
codex/propose-fix-for-alias-fallback-vulnerability
Closed

luvs01 wants to merge 2 commits into
devfrom
codex/propose-fix-for-alias-fallback-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Sep 21, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Close a credential/host identity gap where an alias-derived tenant host could be selected without ensuring the transmitted API key belonged to that alias credential.
  • Prevent cross-account or cross-region exposure of long-lived Devin keys when a devin/devin-cli rekey window and separately-sourced keys coexist.

Description

  • Add an optional apiKey parameter to resolveDevinApiServer and require the alias credential to access === apiKey before borrowing its apiBaseUrl in src/oauth/devin.ts.
  • Pass the resolved adapter key into resolveDevinApiServer from src/adapters/devin.ts so host and key are resolved as a bound snapshot.
  • Add a regression test in tests/providers/devin-adapter.test.ts that proves an independently configured key cannot borrow an alias slot's tenant host, and update tests/providers/devin-login.test.ts to exercise the new binding.
  • Document the invariant in structure/runtime.md and structure/providers-and-adapters.md to declare that alias-host fallback is only allowed when the alias credential owns the transmitted key.

Testing

  • Ran bun test tests/providers/devin-adapter.test.ts tests/providers/devin-login.test.ts and both focused test files passed (66 tests total).
  • Ran bun run typecheck, bun run structure:check, and bun run privacy:scan, all of which succeeded.
  • Ran bun test tests/ci-workflows/file-size-ratchet.test.ts which passed its checks.
  • A full bun run test execution in this container produced unrelated environment/timing and process-group failures (focused Devin coverage passed; full run: 27,761 passed, 34 skipped, 181 failed, 2 errors) so only the focused Devin tests are relied on for regression verification.

Codex Task


Devin Review

devin-ai-integration Bot and others added 2 commits September 20, 2026 13:22
…forwarded role (lidge-jun#5334 follow-up)

lidge-jun#5334 made the developer wire role tri-state: an undeclared destination folds
it to system. Two suites asserting role:"developer" on the Chat wire were
missed because they are about tool-result repair ordering and document parts,
not role selection — declare the destination, per the convention the change
established.

Verified: both files fail on dev@600075d2 with system-for-developer wire roles
and pass with the declaration.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: luvs01/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c41fb60e-c9b8-4a26-900b-c626d478bedf


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T00:27:27.359415Z d225fc2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 21, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@luvs01

luvs01 commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Consolidated into lidge-jun#5541 as a single related-function aggregate.

Source head: d225fc2b6bb507943a8b494b0c3ced0f97def0f6. Replacement head: 6f2901b117b6d8a9a7eae503e795b74749b6e7e0.

All unique Devin contribution commits are carried with original authors and provenance. Six match complete stable patch IDs; the alias-host change matches the code/test/runtime-document patch IDs and its one table-row conflict preserves both contracts. The common f700c56 role-fixture change is already present in both corresponding provider objects on the base, so it was not duplicated. Integration regressions verify exact 429 timing, no raw credential reflection, one physical send, and the alias-bound EU tenant path. Devin tests: 252 passed; layout:18 passed; ratchet:9 passed; typecheck/structure/privacy passed. Full cross-platform CI and independent review remain pending.

Closing this duplicate standalone review entry at the author's request after verifying migration. This is not a merge or release claim; remaining integration checks and reviews are tracked on the draft replacement. Original branches are retained.

@luvs01 luvs01 closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant