Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
…en handling - migrate an owned legacy unauthenticated HTTPS_PROXY env on intercept startup so service-style restarts do not strand Claude Code on 407s - keep status/inspection routes read-only: readClaudeInterceptProxyToken never mints; only apply and runtime startup create the token - publish the proxy token via an atomic no-replace link so concurrent creators converge on the single committed value - update first-party tests, docs guides (en/fr/ja/ko) and structure notes Co-Authored-By: Epinephrine <luvs01@hanmail.net>
…dable reads - read collapses every failure to null so status routes classify a broken token file as stale instead of erroring the request - ensure re-pins an existing token owner-only before trusting it, and publication now goes through the repo's icacls hardener on Windows - settings.json writes use the hardened atomic writer so the embedded credential gets a real per-user ACL off POSIX Co-Authored-By: Epinephrine <luvs01@hanmail.net>
The macos 1/2 leg failed the lidge-jun#848 Bun-runtime-provenance test at 32.8s (20s budget) running the stale merge ref's pre-lidge-jun#5402 eight-snapshot version. Dev commit 24b6a7f (lidge-jun#5402) already replaced it with two reads plus a direct serialization test for the env-marker matrix; a fresh merge ref picks that up. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Motivation
Description
ensureClaudeInterceptProxyToken(src/claude/intercept/proxy-auth.ts).407on missing/invalid credentials (src/claude/intercept/connect-proxy.ts).HTTPS_PROXYURLs carry the credential, and create the token on-demand when starting the intercept pair (src/claude/intercept/runtime.ts,src/claude/desktop-first-party.ts,src/claude/intercept/settings.ts).settings.jsonwrite path to owner-only mode (0600) and preserve migration behavior for legacy unauthenticated proxy URLs; update tests and architecture docs to reflect the authenticated transport contract (tests andstructure/*edits).Testing
bun test tests/claude-integration/claude-intercept-proxy.test.tsandbun test tests/claude-integration/claude-intercept-settings.test.ts, both passing.bun test tests/server/claude-intercept-integration.test.tswhich passed with the authenticated proxy in place.bun run typecheck,bun run structure:check, andbun run privacy:scan, all of which succeeded.bun run testand observed a green run for the executed suite.Codex Task