Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c7b1f51ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rows and missing values. Startup does not rewrite an existing `noVisionModels` entry or | ||
| `modelInputModalities` value: those fields are operator-editable request-routing policy, and a | ||
| saved registry seed is indistinguishable from an intentional restriction without provenance. | ||
| Existing users can opt into the corrected native-vision classification by removing those saved |
There was a problem hiding this comment.
After the startup repair is removed, an existing opencode-go row that inherited the old seed continues routing deepseek-v4.1-flash through the vision sidecar until the user removes both saved overrides. This is a user-visible upgrade requirement, but the only new instruction is in this maintainer-facing structure document; add the cleanup steps and the corrected OpenCode Go classification to the relevant English docs-site/ provider or sidecar guide and keep its translations consistent.
AGENTS.md reference: AGENTS.md:L434-L435
Useful? React with 👍 / 👎.
1 participant
Motivation
noVisionModelsandmodelInputModalitiesentries that may be intentional operator policy, which could remove fail-closed image stripping and forward raw images upstream.Description
src/providers/stale-vision-classification-migration.tsand stopped invoking it fromsrc/providers/model-rename-startup.ts, so startup no longer rewrites existingnoVisionModelsormodelInputModalitiesvalues.derive.tsfills missing registry metadata but does not replace saved operator values insrc/providers/registry/entries-core.ts.tests/providers/vision-classification-seed-repair.test.tsthat assert explicit text-only policies andnoVisionModelsrestrictions are preserved and continue to require vision preprocessing.structure/providers-and-adapters.mdto explain why startup must not rewrite indistinguishable operator restrictions and how operators can opt into the corrected registry classification.Testing
bun test tests/providers/vision-classification-seed-repair.test.ts tests/providers/model-rename-migration.test.ts tests/providers/devin-cli-authmode-migration.test.tsand they passed.bun test tests/test-layout.test.ts tests/test-layout-tooling.test.tsand they passed.bun run typecheck,bun run structure:check, andbun run privacy:scan, all of which passed.bun run test; the full suite did not complete within the container run time (attempt stopped) but focused regressions and static checks passed.Codex Task