fix: install setuptools explicitly in the macOS and upload jobs - #61
Merged
Merged
Conversation
Removing setuptools_rust also removed the only thing pulling setuptools into these two jobs, and it is no longer bundled with Python 3.12+, so `python setup.py bdist_wheel` failed with ModuleNotFoundError: setuptools. build-windows and the regression suite already installed it explicitly, and build-manylinux gets it from build.sh, so only these two were affected. Reproduced in a clean venv (same traceback, same line) and confirmed both bdist_wheel and sdist succeed with setuptools installed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing setuptools_rust also removed the only thing pulling setuptools into these two jobs, and it is no longer bundled with Python 3.12+, so
python setup.py bdist_wheelfailed with ModuleNotFoundError: setuptools.build-windows and the regression suite already installed it explicitly, and build-manylinux gets it from build.sh, so only these two were affected.
Reproduced in a clean venv (same traceback, same line) and confirmed both bdist_wheel and sdist succeed with setuptools installed.