e2e/qa: name the gate for instant_allocation_price, not a version - #4166
Merged
Conversation
The skip path pinned "0.5.10-1 at time of writing" in both the comment and the skip message. Testnet has since moved to 0.5.11-1, so anyone reading either one got a wrong picture of why the subtest skips: it reads as though the pin is behind, when the field is in no release yet. Point at the thing that actually gates it, doublezero-offchain#405, and at where the pin lives. Both stay true as versions move.
ben-dz
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestQA_MulticastSettlement'svalidate_instant_allocation_price_matches_chainskip path named a specific pinned version in two places:Testnet moved to
0.5.11-1some time ago, so both read as "the pin is behind, bump it". It isn't.instant_allocation_pricelanded in doublezero-offchain#405 and is still under## [Unreleased]there, so no published release carries it and no bump helps yet. That cost real time this week while debugging aquery_onchain_seat_pricefailure on testnet.Summary
*corrected to<env>.Testing Verification
gofmtclean andgo vet -tags=qa ./e2e/passes.