Describe MySQL data type mapping and update to latest Malloy - #343
Merged
Conversation
ModelDef gained required `modelID` and `modelAnnotations` fields, and `ModelDef.annotation` is gone. The notebook builder hand-built an empty ModelDef for the first cell to extend, so every runnable cell in every notebook failed to compile. Drop the fabricated seed — the first cell now compiles with `loadModel` and has nothing to extend, matching what the VS Code extension does for notebook cells. Read a cell's own `##` via `model.annotations`, and give each cell its own `#cellN` URL so the model-annotation closure is a real chain and `##!` experiment flags survive across cells. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ht4FirdWFj7oukC2mxVJxa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe MySQL data type mapping, and update to the latest Malloy (0.0.433).
The Malloy bump needed a matching change in the notebook builder:
ModelDefgained required fields, so the hand-built empty model def the first cell extended no longer compiled. The first cell now usesloadModeland extends nothing, the same way the VS Code extension chains notebook cells.