Skip to content

fix jacocoTestReport generation#263

Merged
filiphr merged 1 commit into
mapstruct:mainfrom
hduelme:fix-jacocoTestReport-generation
May 17, 2026
Merged

fix jacocoTestReport generation#263
filiphr merged 1 commit into
mapstruct:mainfrom
hduelme:fix-jacocoTestReport-generation

Conversation

@hduelme

@hduelme hduelme commented May 17, 2026

Copy link
Copy Markdown
Contributor

@filiphr It looks like coverage reporting has been broken for a while. I traced the issue back to the jacocoTestReport job.

We’re not actually using instrumentCode, but it was still configured for that job.

@hduelme hduelme requested a review from filiphr May 17, 2026 12:34

@filiphr filiphr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me @hduelme. However, what does it do? Does it mean that we do generate a coverage report now? I do see the jacocoTestReport as a warning in the logs

@hduelme

hduelme commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

@filiphr yes in this PR we are generating a coverage report again https://app.codecov.io/gh/mapstruct/mapstruct-idea/pull/263.

Seems like updating the idea version caused instrumentCode to be filled, resulting in invalid referenced files.

@filiphr filiphr merged commit 809bb60 into mapstruct:main May 17, 2026
6 of 7 checks passed
@filiphr

filiphr commented May 17, 2026

Copy link
Copy Markdown
Member

Great. Nice catch @hduelme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants