TEST#4
Open
marelab wants to merge 4753 commits into
Open
Conversation
Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
These configs were generated programatically by Opus 4.6. See: https://github.com/vidplace7/meshtasticd-40pin Tested with MeshAdv-Pi, other pinmaps are untested but should work.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
These configs were generated programatically by Opus 4.6. See: https://github.com/vidplace7/meshtasticd-40pin Tested with MeshAdv-Pi, other pinmaps are untested but should work.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Use Google / Amazon mirrors, not DockerHub, when pulling images for Docker builds. Should prevent Docker ratelimiting during CI (Actions) builds.
* Upload to PPA via SFTP * PPA-SFTP: Trust Launchpad's SSH Key * Move SSH key import next to GPG * Increase dput timeout... * Use env for inputs (address semgrep gripe)
…10146) Addresses cppcheck `src/graphics/EInkParallelDisplay.cpp:205: [low:style] Variable 'prev' can be declared as pointer to const [constVariablePointer]`
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ronization (#9895) * fix(native): implement BinarySemaphorePosix with proper pthread synchronization The BinarySemaphorePosix class (used on all Linux/portduino/native builds) had stub implementations: give() was a no-op and take() just called delay(msec) and returned false. This broke the cooperative thread scheduler on native platforms — threads could not wake the main loop, radio RX interrupts were missed, and telemetry never transmitted over the mesh. Replace the stubs with a proper binary semaphore using pthread_mutex_t + pthread_cond_t + bool signaled: - take(msec): pthread_cond_timedwait with CLOCK_REALTIME timeout, consumes signal atomically (binary semaphore semantics) - give(): sets signaled=true, signals condition variable - giveFromISR(): delegates to give(), sets pxHigherPriorityTaskWoken Tested on Raspberry Pi 3 Model B (ARM64, Debian Bookworm) with Adafruit LoRa Radio Bonnet (SX1276). Before fix: no radio TX/RX, no telemetry on mesh. After fix: bidirectional LoRa, MQTT gateway, telemetry all working. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * ARCH_PORTDUINO * Refactor BinarySemaphorePosix header for ARCH_PORTDUINO * Change preprocessor directive from ifndef to ifdef * Gate new Semaphore code to Portduino and fix STM compilation * Binary Semaphore Posix better error handling --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
* Fix heap blowout on TBeams * Update src/graphics/draw/MessageRenderer.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Set MESSAGE_HISTORY_LIMIT to 10 for original ESP32 to optimize RAM usage * Optimize message frame allocation to prevent excessive memory usage * Refine message history limits for resource-constrained builds and cap cached lines to prevent heap overflow * Update src/graphics/draw/MessageRenderer.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
) * Initial plan * fix(FSCommon): add file.name()[0] guard in getFiles() for nRF52 LittleFS bug workaround * style(FSCommon): run clang-format (trunk fmt) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
…#10754) * fix(fs): bound getFiles() result size and harden traversal The recursive filesystem traversal in getFiles() could grow its result vector without limit, contributing to heap pressure on memory-constrained devices during client config starts. The implementation also relied on unbounded strcpy and per-entry String() allocations for dot-suffix filtering, and leaked the directory handle when the opened path was not a directory. Rework the traversal to address all of those at once: - Add optional maxCount (default 64) and wasLimited out-param. The walk stops once maxCount entries have been collected and wasLimited is set, so callers can distinguish a complete listing from a truncated one. Default arguments preserve backward compatibility for existing callers. - Extract the recursive walk into a collectFiles() helper in an anonymous namespace, accumulating into a single caller-owned vector instead of building and inserting temporary vectors at every recursion level. - Replace strcpy with strlcpy so file_name writes are bounded by the destination buffer. - Replace String(name).endsWith(".") with a stack-based pathEndsWithDot() helper to avoid a heap allocation per entry. - Close the directory handle when the opened path is not a directory, and close the file in both branches of recursion instead of only the leaf branch (the previous code leaked the handle when depth was exhausted). - Compile-gate the std::bad_alloc reserve probe-down behind __cpp_exceptions / __EXCEPTIONS so the fallback only compiles where bad_alloc is actually catchable. No-exception targets (nRF52, RP2040, STM32, ESP32-C6) skip the probe and rely on the bounded maxCount alone, which is safe because the default cap is small enough to fit comfortably in available RAM on every supported platform. * fix(phone-api): skip manifest scan for node-info-only config requests A client can request a node-info-only config response by sending want_config_id with the SPECIAL_NONCE_ONLY_NODES nonce. The manifest walk in handleStartConfig() ran unconditionally even though STATE_SEND_FILEMANIFEST short-circuits past the manifest on that path, so the SPI lock and recursive filesystem traversal were wasted work. On memory-constrained devices this extra heap pressure was enough to trigger allocation aborts and spontaneous reboots before the node-info response could complete. Gate the manifest call behind config_nonce != SPECIAL_NONCE_ONLY_NODES so the node-info-only path no longer touches the filesystem at all, and release any stale manifest storage left over from a previous run. For normal full-config requests, also tighten the scan limits from depth 10 / unbounded to depth 3 / max 64 entries via the new getFiles() parameters. A 10-level recursive listing was never useful for a client file picker and amplified heap pressure for no benefit. Log a warning when the listing was truncated so operators can distinguish a bounded result from a genuinely empty filesystem. A few small cleanups fall out of the above: - Replace raw spiLock->lock()/unlock() with a LockGuard so the lock is released even if getFiles() throws on exception-enabled targets. - Use a releaseFilesManifest() helper (swap-with-empty idiom) in close() and the STATE_SEND_FILEMANIFEST drain path instead of the previous clear()+shrink_to_fit() pair. Equivalent behavior, but the swap idiom is the canonical vector-freeing pattern and centralizing it avoids divergence between call sites. - Use %zu for the size_t log arguments. * fix(fs): harden bounded directory traversal Close each child directory entry before recursive descent so bounded manifest scans do not stack file handles on constrained filesystems. Treat null or overlong paths as truncated listings, handle reserve length failures like allocation failures, and keep manifest constants aligned with repository naming. * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
) * fix(nrf52): restore BLE security state on resume NRF52Bluetooth::shutdown() swaps the passkey callback to onUnwantedPairing() while Bluetooth is disabled. resumeAdvertising() used to restart GAP advertising without rebuilding that security state, which could leave the node advertising while normal pairing attempts were still rejected until reboot. Restore the configured security state before advertising resumes. PIN-based modes reinstall the pairing, completion, and secured callbacks, explicitly restore display-only IO capabilities, and explicitly require MITM. NO_PIN mode clears those callbacks and clears MITM after setPairPasskeyCallback(nullptr), because Bluefruit enables MITM as a callback-setter side effect even when clearing the callback. Share the same restore helpers with setup(), keep TX power setup symmetric with the resume path, and log unexpected onUnwantedPairing() hits so callback poisoning is visible in diagnostics. * fix(nrf52): remove blocking BLE pairing wait NRF52Bluetooth::onPairingPasskey() blocked the firmware loop for up to 30 seconds when match_request was true. That wait did not yield or delay, so it could starve application-level BLE event handling while the SoftDevice connection was active. Remove the busy-wait. The passkey UI remains visible because pairing completion and disconnect callbacks already dismiss it, so pairing can continue through the normal callback flow without stalling the rest of the firmware. * fix(nrf52): redact BLE pairing secrets from logs The nRF52 BLE pairing path logged both the configured boot PIN and the per-pairing passkey at INFO level. Those values can be exposed through serial diagnostics or log streaming even though they are intended only for the pairing UI and status observers. Keep the diagnostic signal without printing secret digits: log that a PIN is configured, log the pairing start with match_request state, and remove the now-unused passkey-splitting locals and duplicate match_request log.
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
Avoid nested spiLock acquisition in MessageStore::clearAllMessages() by only holding the lock during the write() call. SafeFile's constructor and close() methods already handle their own spiLock acquisition, so nesting the guard around the entire operation causes a deadlock until the watchdog timer triggers a reset. Relates to PR #10809.
The automated trunk upgrade (#10865) enabled ascii-dash@SYSTEM and too-many-defined@SYSTEM without any lint.definitions for them, so trunk reports 'not a supported linter' (trunk/config-error) and fails the Trunk Check on every open PR. trunk_check.yml runs on pull_request only, so master's push CI never caught it. Remove the two undefined entries to restore a valid config; the version bumps from #10865 are kept.
* Backport Tracker X1 to Master * Add SPA06 to generated TelemetrySensorType enum * Rename TRACKER_T1000_E_PRO to MESH_TRACKER_X1 in generated HardwareModel enum * Update RadioLib dependency to the fixed version --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
Trunk loves to complain about svgs and pngs in `branding`. Make it stop!
…10927) Back-port of #10911 to master. Adds support for boards that route the SX126x control lines (NRESET/DIO1/BUSY) through an I2C GPIO expander with no /INT wired to the MCU, so RadioLib cannot take a hardware DIO1 interrupt. Two reusable pieces, both gated behind USE_MCP23017 / LORA_DIO1_SOFTWARE_POLL so builds that don't define them are unaffected: - ExtensionIOMCP23017 + MCP23017LockingArduinoHal: a RadioLib HAL that maps virtual pins (MCP23017_VPIN_BASE .. +15) onto an MCP23017's GPIO, so RESET/BUSY/DIO1 reads and writes become I2C transactions while the real SPI GPIOs (SCK/MOSI/MISO/CS) pass straight through. A failed I2C read skips the read-modify-write rather than clobbering the rest of the bank. Expander access is mutex-guarded since it is touched from both the radio thread and setup. - LORA_DIO1_SOFTWARE_POLL: with no DIO1 interrupt available, the SX126x interface polls the radio IRQ status register from the radio thread and synthesizes the ISR_TX/ISR_RX events, filtering noisy preamble/header IRQs so they can't starve TX. A 1 ms ISR_POLL_TICK drives the poll; TX timers may overwrite the pending tick (pollMissedIrqs() bounds the busy-Rx contention latency). Behaviour is unchanged on boards that keep the hardware interrupt. Variants opt into shared behavior via reusable capability macros instead of per-model #ifdefs: AUDIO_AMP_ENABLE(on) (speaker amp power, shared with the T-LoRa Pager) and LORA_DIO1_EXTENDED_IO (DIO1 lives on an expander, not a wake-capable GPIO; shared with the SenseCAP Indicator so sleep.cpp skips the GPIO wakeup path). The Meshnology W10 variant: ESP32-S3R8 + EBYTE E22-900MM22S (SX1262) + AXP2101 PMIC + Quectel L76KB GPS + SPI TFT + ES8311 codec, with the radio's RESET/DIO1/BUSY and the LCD reset routed through an MCP23017 at 0x20. Pins come from the board schematic and were verified on hardware. master's protobufs predate the MESHNOLOGY_W10 HardwareModel enum, so the board reports PRIVATE_HW until that enum lands here via a protobuf bump.
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
* rebased to master * Update bin/config.d/lora-ZebraHat_2W.yaml Co-authored-by: Austin <vidplace7@gmail.com> * Update bin/config.d/lora-ZebraHat_1W.yaml Co-authored-by: Austin <vidplace7@gmail.com> * Update bin/config.d/lora-NebraHat_2W.yaml Co-authored-by: Austin <vidplace7@gmail.com> * Update bin/config.d/lora-NebraHat_1W.yaml Co-authored-by: Austin <vidplace7@gmail.com> * Remove TX_GAIN_LORA configuration line * Remove TX_GAIN_LORA configuration line * Comment out TX_GAIN_LORA configuration * Comment out TX_GAIN_LORA configuration * Update lora-ok3506-RAK6421-13300-slot1.yaml * Update lora-ok3506-RAK6421-13300-slot2.yaml * Update lora-RAK6421-13300-slot1.yaml * Update lora-RAK6421-13300-slot2.yaml * Added Zebra Hat Duo --------- Co-authored-by: Austin <vidplace7@gmail.com>
…ardputer Advanced (#10884) * Implement SD card backup/restore of preferences; add SD support for Cardputer Advanced Fills the two 'TODO: After more mainline SD card support' stubs in NodeDB::backupPreferences / restorePreferences so the existing backup_preferences / restore_preferences admin messages work with BackupLocation_SD. Same BackupPreferences proto as the FLASH location, stored at /backups/backup.proto on the card; guarded by HAS_SDCARD && !SDCARD_USE_SOFT_SPI; SD access under spiLock. Also defines the SD card slot pins for the M5Stack Cardputer Advanced (shares the SPI bus with the SX1262, separate CS), whose physical slot was previously unused by the firmware. Hardware-tested on two Cardputer Advanced units (as a v2.7.26 backport): mount, backup write, and full restore (config, module config, channels, owner, security keys) verified; LoRa unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Deduplicate backup construction and restore application Extract buildBackupPreferences() and applyRestoredPreferences() shared by the FLASH and SD locations, per review feedback, so the two paths cannot drift apart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Maksym Tereshko <maxim.tereshko@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Maksym Tereshko <termax@ter-air-12.taila94f88.ts.net>
Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>
Includes HM330X sensor used at the fab26 event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for sending in a pull request, here's some tips to get started!
(Please delete all these tips and replace with your text)
to say "hey, I think this idea X should be implemented and I'm starting work on it. My general plan is Y, any feedback
is appreciated." This will allow other devs to potentially save you time by not accidentially duplicating work etc...
because it automatically follows our indentation rules and its auto reformatting will not cause spurious changes to lines.