fix: export source entry for React Native - #348
Open
chrispader wants to merge 1 commit into
Open
Conversation
Extracted from #298. Co-authored-by: Samuel Scheit <github@samuelscheit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Native consumers can resolve
react-native-nitro-sqlitethrough the packageexportsmap, but that map currently exposes only the built ESM and CommonJS entry points. Metro therefore cannot select the package source when it resolves the package through conditional exports. This PR extracts the React Native source condition from #298 so the package fix can be reviewed independently of macOS support.The new condition points to
src/index.ts, which is already included in the publishedfileslist. Metro selects that source entry for both iOS and Android, while ordinary ESM imports and CommonJS requires retain their existing built targets. No example-wide Metro alias is needed for installed-package resolution.Originally authored by @samuelscheit in #298.
Closes #344.