fix: Compile Android resizer shaders on AGP 9 - #4190
Open
mrousavy wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On AGP 9, the resizer's shader can be omitted from app assets, causing the first
resize()call to fail. Shader compilation is disabled by default, and enabling AGP's built-in task requires a compiler path in the consuming app'slocal.properties.Compile
Resizer.compduring the consumer's build usingglslcfrom the selected NDK, and register its output with AGP's generated-assets API. The task tracks the shader directory and compiler as inputs, including changes to shader includes. Disable the built-in shader task to avoid duplicate compilation on AGP 8.Include the new Gradle script in the npm package. Existing debug Harness CI builds the consumer app and exercises the resizer on supported devices.
Fixes #4183.
Validated on macOS with NDK 29 and compile SDK 36:
spirv-val.npm pack --dry-runincludes the Gradle script and shader source.GPU execution on a device was not tested.